From: Pratyush Yadav <p.yadav@ti.com>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: <linux-mtd@lists.infradead.org>,
<linux-rockchip@lists.infradead.org>, <andy.yan@rock-chips.com>,
<yifeng.zhao@rock-chips.com>, <sugar.zhang@rock-chips.com>,
<tudor.ambarus@microchip.com>, <michael@walle.cc>,
<heiko@sntech.de>, <robh+dt@kernel.org>, <vigneshr@ti.com>,
<richard@nod.at>, <miquel.raynal@bootlin.com>,
Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH 1/3] mtd: spi-nor: add rockchip serial flash controller driver
Date: Thu, 27 May 2021 15:46:01 +0530 [thread overview]
Message-ID: <20210527101601.24qauggye5yzjfad@ti.com> (raw)
In-Reply-To: <20210526181636.1130-2-macroalpha82@gmail.com>
On 26/05/21 01:16PM, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Add the rockchip serial flash controller (SFC) driver.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
> drivers/mtd/spi-nor/controllers/Kconfig | 7 +
> drivers/mtd/spi-nor/controllers/Makefile | 1 +
> .../mtd/spi-nor/controllers/rockchip-sfc.c | 944 ++++++++++++++++++
NACK. Please don't add controller drivers here. Instead use the SPI MEM
(drivers/spi/spi-mem.c) framework and put the drivers in drivers/spi/.
See the history for drivers/spi/spi-cadence-quadspi.c for an example
conversion. I recall mentioning this on IRC as well, but maybe my memory
misleads me.
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-05-27 10:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 18:16 [PATCH 0/3] Add Rockchip SFC(serial flash controller) support Chris Morgan
2021-05-26 18:16 ` [PATCH 1/3] mtd: spi-nor: add rockchip serial flash controller driver Chris Morgan
2021-05-27 10:16 ` Pratyush Yadav [this message]
2021-05-26 18:16 ` [PATCH 2/3] mtd: spi-nor: Bindings for Rockchip serial flash controller Chris Morgan
2021-05-26 18:16 ` [PATCH 3/3] arm64: dts: rockchip: Add SFC to PX30 Chris Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210527101601.24qauggye5yzjfad@ti.com \
--to=p.yadav@ti.com \
--cc=andy.yan@rock-chips.com \
--cc=heiko@sntech.de \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=sugar.zhang@rock-chips.com \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
--cc=yifeng.zhao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox