Re: [PATCH 07/10] ARM: dts: rockchip: add vpu node for RK322x

Heiko Stübner
2021-05-25T23:06:20Z

Am Dienstag, 25. Mai 2021, 17:22:22 CEST schrieb Alex Bee:
> The VPU IP block of RK322x is the same as RK3399 has and the driver can
> be used as-is.
>
> Add the respective nodes to the device tree.
>
> Signed-off-by: Alex Bee <knaerzche@gmail.com>
> ---
> arch/arm/boot/dts/rk322x.dtsi | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi
> index c8095ede7d7a..62d1113b7804 100644
> --- a/arch/arm/boot/dts/rk322x.dtsi
> +++ b/arch/arm/boot/dts/rk322x.dtsi
> @@ -611,6 +611,18 @@ gpu: gpu@20000000 {
> status = "disabled";
> };
>
> + vpu: video-codec@20020000 {
> + compatible = "rockchip,rk3228-vpu", "rockchip,rk3399-vpu";
> + reg = <0x20020000 0x800>;
> + interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "vepu", "vdpu";
> + clocks = <&cru ACLK_VPU>, <&cru HCLK_VPU>;
> + clock-names = "aclk", "hclk";
> + power-domains = <&power RK3228_PD_VPU>;
> + iommus = <&vpu_mmu>;

NIT: [if you need to resend for other reasons] iommus before power-domains please

> + };
> +
> vpu_mmu: iommu@20020800 {
> compatible = "rockchip,iommu";
> reg = <0x20020800 0x100>;
> @@ -619,7 +631,6 @@ vpu_mmu: iommu@20020800 {
> clock-names = "aclk", "iface";
> power-domains = <&power RK3228_PD_VPU>;
> #iommu-cells = <0>;
> - status = "disabled";
> };
>
> vdec_mmu: iommu@20030480 {