From: "jay.xu@rock-chips.com" <jay.xu@rock-chips.com>
To: "Mark Brown" <broonie@kernel.org>
Cc: lgirdwood <lgirdwood@gmail.com>,
"ulf.hansson" <ulf.hansson@linaro.org>,
"Lee Jones" <lee.jones@linaro.org>,
"Zhang Changzhong" <zhangchangzhong@huawei.com>,
"Heiko Stübner" <heiko@sntech.de>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH 2/4] regulator: core: notify regulator enable with the voltage value
Date: Tue, 17 Aug 2021 11:17:55 +0800 [thread overview]
Message-ID: <202108171117556125066@rock-chips.com> (raw)
In-Reply-To: 20210816120059.GA4253@sirena.org.uk
Hi, Mark
--------------
jay.xu@rock-chips.com
>On Mon, Aug 16, 2021 at 11:20:01AM +0800, Jianqun Xu wrote:
>
>> + ret = _regulator_get_voltage(rdev);
>> + if (ret < 0)
>> + ret = 0;
>> +
>> _notifier_call_chain(rdev, REGULATOR_EVENT_ENABLE,
>> - NULL);
>> + &ret);
>
>This is going to be really expensive for devices without a cache and
>it's going to be *very* rarely used if ever.
How about to only to notify the EVENT_ENABLE without get voltage, then driver who care about this event
could get the voltage itself ?
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-08-17 3:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 3:19 [PATCH 0/4] regulator pre-enable Jianqun Xu
2021-08-16 3:20 ` [PATCH 1/4] regulator: add PRE_ENABLE event define Jianqun Xu
2021-08-16 3:20 ` [PATCH 2/4] regulator: core: notify regulator enable with the voltage value Jianqun Xu
2021-08-16 12:00 ` Mark Brown
2021-08-17 3:17 ` jay.xu [this message]
2021-08-17 3:23 ` jay.xu
2021-08-16 3:20 ` [PATCH 3/4] regulator: core: add pre-enable event notify to regulator Jianqun Xu
2021-08-16 3:20 ` [PATCH 4/4] soc: rockchip: io-domain: do more thing about regulator notify Jianqun Xu
2021-08-16 12:39 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202108171117556125066@rock-chips.com \
--to=jay.xu@rock-chips.com \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=ulf.hansson@linaro.org \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox