From: kernel test robot <lkp@intel.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org
Cc: kbuild-all@lists.01.org, Dafna Hirschfeld <dafna@fastmail.com>,
Heiko Stuebner <heiko@sntech.de>,
Paul Elder <paul.elder@ideasonboard.com>,
Tomasz Figa <tfiga@google.com>,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v3 13/17] media: rkisp1: Compile debugfs support conditionally
Date: Mon, 21 Mar 2022 20:11:57 +0800 [thread overview]
Message-ID: <202203212003.ngntIuxj-lkp@intel.com> (raw)
In-Reply-To: <20220319163100.3083-14-laurent.pinchart@ideasonboard.com>
Hi Laurent,
I love your patch! Yet something to improve:
[auto build test ERROR on 71e6d0608e4d1b79069990c7dacb3600ced28a3b]
url: https://github.com/0day-ci/linux/commits/Laurent-Pinchart/media-rkisp1-Misc-bug-fixes-and-cleanups/20220320-003349
base: 71e6d0608e4d1b79069990c7dacb3600ced28a3b
config: m68k-randconfig-r015-20220320 (https://download.01.org/0day-ci/archive/20220321/202203212003.ngntIuxj-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/11c5c07e897814001cfa8356922aeea602844787
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Laurent-Pinchart/media-rkisp1-Misc-bug-fixes-and-cleanups/20220320-003349
git checkout 11c5c07e897814001cfa8356922aeea602844787
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash drivers/media/platform/rockchip/rkisp1/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c:16:6: error: redefinition of 'rkisp1_debug_init'
16 | void rkisp1_debug_init(struct rkisp1_device *rkisp1)
| ^~~~~~~~~~~~~~~~~
In file included from drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c:14:
drivers/media/platform/rockchip/rkisp1/rkisp1-common.h:525:20: note: previous definition of 'rkisp1_debug_init' with type 'void(struct rkisp1_device *)'
525 | static inline void rkisp1_debug_init(struct rkisp1_device *rkisp1)
| ^~~~~~~~~~~~~~~~~
>> drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c:47:6: error: redefinition of 'rkisp1_debug_cleanup'
47 | void rkisp1_debug_cleanup(struct rkisp1_device *rkisp1)
| ^~~~~~~~~~~~~~~~~~~~
In file included from drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c:14:
drivers/media/platform/rockchip/rkisp1/rkisp1-common.h:528:20: note: previous definition of 'rkisp1_debug_cleanup' with type 'void(struct rkisp1_device *)'
528 | static inline void rkisp1_debug_cleanup(struct rkisp1_device *rkisp1)
| ^~~~~~~~~~~~~~~~~~~~
vim +/rkisp1_debug_init +16 drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c
2521809005c614 Laurent Pinchart 2022-03-19 15
2521809005c614 Laurent Pinchart 2022-03-19 @16 void rkisp1_debug_init(struct rkisp1_device *rkisp1)
2521809005c614 Laurent Pinchart 2022-03-19 17 {
2521809005c614 Laurent Pinchart 2022-03-19 18 struct rkisp1_debug *debug = &rkisp1->debug;
2521809005c614 Laurent Pinchart 2022-03-19 19
2521809005c614 Laurent Pinchart 2022-03-19 20 debug->debugfs_dir = debugfs_create_dir(dev_name(rkisp1->dev), NULL);
2521809005c614 Laurent Pinchart 2022-03-19 21
2521809005c614 Laurent Pinchart 2022-03-19 22 debugfs_create_ulong("data_loss", 0444, debug->debugfs_dir,
2521809005c614 Laurent Pinchart 2022-03-19 23 &debug->data_loss);
2521809005c614 Laurent Pinchart 2022-03-19 24 debugfs_create_ulong("outform_size_err", 0444, debug->debugfs_dir,
2521809005c614 Laurent Pinchart 2022-03-19 25 &debug->outform_size_error);
2521809005c614 Laurent Pinchart 2022-03-19 26 debugfs_create_ulong("img_stabilization_size_error", 0444,
2521809005c614 Laurent Pinchart 2022-03-19 27 debug->debugfs_dir,
2521809005c614 Laurent Pinchart 2022-03-19 28 &debug->img_stabilization_size_error);
2521809005c614 Laurent Pinchart 2022-03-19 29 debugfs_create_ulong("inform_size_error", 0444, debug->debugfs_dir,
2521809005c614 Laurent Pinchart 2022-03-19 30 &debug->inform_size_error);
2521809005c614 Laurent Pinchart 2022-03-19 31 debugfs_create_ulong("irq_delay", 0444, debug->debugfs_dir,
2521809005c614 Laurent Pinchart 2022-03-19 32 &debug->irq_delay);
2521809005c614 Laurent Pinchart 2022-03-19 33 debugfs_create_ulong("mipi_error", 0444, debug->debugfs_dir,
2521809005c614 Laurent Pinchart 2022-03-19 34 &debug->mipi_error);
2521809005c614 Laurent Pinchart 2022-03-19 35 debugfs_create_ulong("stats_error", 0444, debug->debugfs_dir,
2521809005c614 Laurent Pinchart 2022-03-19 36 &debug->stats_error);
2521809005c614 Laurent Pinchart 2022-03-19 37 debugfs_create_ulong("mp_stop_timeout", 0444, debug->debugfs_dir,
2521809005c614 Laurent Pinchart 2022-03-19 38 &debug->stop_timeout[RKISP1_MAINPATH]);
2521809005c614 Laurent Pinchart 2022-03-19 39 debugfs_create_ulong("sp_stop_timeout", 0444, debug->debugfs_dir,
2521809005c614 Laurent Pinchart 2022-03-19 40 &debug->stop_timeout[RKISP1_SELFPATH]);
2521809005c614 Laurent Pinchart 2022-03-19 41 debugfs_create_ulong("mp_frame_drop", 0444, debug->debugfs_dir,
2521809005c614 Laurent Pinchart 2022-03-19 42 &debug->frame_drop[RKISP1_MAINPATH]);
2521809005c614 Laurent Pinchart 2022-03-19 43 debugfs_create_ulong("sp_frame_drop", 0444, debug->debugfs_dir,
2521809005c614 Laurent Pinchart 2022-03-19 44 &debug->frame_drop[RKISP1_SELFPATH]);
2521809005c614 Laurent Pinchart 2022-03-19 45 }
2521809005c614 Laurent Pinchart 2022-03-19 46
2521809005c614 Laurent Pinchart 2022-03-19 @47 void rkisp1_debug_cleanup(struct rkisp1_device *rkisp1)
--
0-DAY CI Kernel Test Service
https://01.org/lkp
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2022-03-21 12:12 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-19 16:30 [PATCH v3 00/17] media: rkisp1: Misc bug fixes and cleanups Laurent Pinchart
2022-03-19 16:30 ` [PATCH v3 01/17] media: rkisp1: capture: Initialize entity before video device Laurent Pinchart
2022-03-19 16:30 ` [PATCH v3 02/17] media: rkisp1: capture: Fix and simplify (un)registration Laurent Pinchart
2022-03-19 16:30 ` [PATCH v3 03/17] media: rkisp1: isp: " Laurent Pinchart
2022-03-22 4:23 ` Dafna Hirschfeld
2022-03-22 9:58 ` Laurent Pinchart
2022-03-19 16:30 ` [PATCH v3 04/17] media: rkisp1: resizer: " Laurent Pinchart
2022-03-19 16:30 ` [PATCH v3 05/17] media: rkisp1: params: " Laurent Pinchart
2022-03-22 4:27 ` Dafna Hirschfeld
2022-03-22 10:01 ` Laurent Pinchart
2022-03-19 16:30 ` [PATCH v3 06/17] media: rkisp1: stats: Simplify (un)registration Laurent Pinchart
2022-03-19 16:30 ` [PATCH v3 07/17] media: rkisp1: Simplify rkisp1_entities_register() error path Laurent Pinchart
2022-03-19 16:30 ` [PATCH v3 08/17] media: rkisp1: regs: Don't use BIT() macro for multi-bit register fields Laurent Pinchart
2022-03-22 5:07 ` Dafna Hirschfeld
2022-03-19 16:30 ` [PATCH v3 09/17] media: rkisp1: regs: Rename CCL, ICCL and IRCL registers with VI_ prefix Laurent Pinchart
2022-03-22 5:12 ` Dafna Hirschfeld
2022-03-19 16:30 ` [PATCH v3 10/17] media: rkisp1: Swap value and address arguments to rkisp1_write() Laurent Pinchart
2022-03-22 4:37 ` Dafna Hirschfeld
2022-03-19 16:30 ` [PATCH v3 11/17] media: rkisp1: resizer: Simplify register access Laurent Pinchart
2022-03-19 16:30 ` [PATCH v3 12/17] media: rkisp1: Move debugfs code to a separate file Laurent Pinchart
2022-03-22 4:12 ` Dafna Hirschfeld
2022-03-19 16:30 ` [PATCH v3 13/17] media: rkisp1: Compile debugfs support conditionally Laurent Pinchart
2022-03-21 12:11 ` kernel test robot [this message]
2022-03-21 12:44 ` [PATCH v3.1 " Laurent Pinchart
2022-03-22 4:12 ` Dafna Hirschfeld
2022-03-19 16:30 ` [PATCH v3 14/17] media: rkisp1: debug: Collect input status by sampling ISP_FLAGS_SHD Laurent Pinchart
2022-03-22 3:56 ` Dafna Hirschfeld
2022-03-22 8:32 ` Laurent Pinchart
2022-03-25 18:22 ` Dafna Hirschfeld
2022-03-19 16:30 ` [PATCH v3 15/17] media: rkisp1: debug: Add debugfs files to dump core and ISP registers Laurent Pinchart
2022-03-22 5:25 ` Dafna Hirschfeld
2022-03-22 10:08 ` Laurent Pinchart
2022-03-19 16:30 ` [PATCH v3 16/17] media: rkisp1: debug: Move resizer register dump to debugfs Laurent Pinchart
2022-03-22 5:28 ` Dafna Hirschfeld
2022-03-22 10:10 ` Laurent Pinchart
2022-03-19 16:31 ` [PATCH v3 17/17] media: rkisp1: capture: Bypass the main device for handling querycap Laurent Pinchart
2022-03-22 5:08 ` Dafna Hirschfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202203212003.ngntIuxj-lkp@intel.com \
--to=lkp@intel.com \
--cc=dafna@fastmail.com \
--cc=heiko@sntech.de \
--cc=kbuild-all@lists.01.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=paul.elder@ideasonboard.com \
--cc=tfiga@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox