From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFA80C433F5 for ; Tue, 22 Mar 2022 04:13:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HUHbMZ/w9e7hHlhpYV2ogjJ3+SYGBvDOLXpNBEbynEg=; b=etiMV0MJBtxdlc c2AvS0YNtfiHRF8S05kXTs8fn3c3srHFGm12m3NHgZbrxc1Fl2RnJaYdCWzpI242oNlPAgxdeVvLD JLGbToFv31TeJtOcsnCw+0LuM6eKGEeBERVo/Vyw539p/4aOs98RGVOgBtNdCYIW0LO65j2yrThyc mPfOh7qFgh9KIyknPhx81SpBOBy4OZl6m7c+CMwUbKOjZ7D5KzrUTpkFym2P809KbXEuhblFCeaLu U/NQBMwLENNJ/aRafy2SfIcg/J4z+gPREr/8yra+1Zi1m4aTq7yERTgJ/m8NzCU+MuXcjjmLrrS6i dzKKdv8Zh2TbxHFpEhdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWVtJ-009xBs-VD; Tue, 22 Mar 2022 04:13:05 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWVtF-009xB9-LB for linux-rockchip@lists.infradead.org; Tue, 22 Mar 2022 04:13:04 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 0A6305C00DE; Tue, 22 Mar 2022 00:13:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 22 Mar 2022 00:13:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=vEQSr42CnQBUPKCEub5pbkgSu3hQM6IuMYKUXj ZSfOA=; b=omf5Gpc21hgtKBKgxupOrRvO6vkTAs4G5BiYCTFRELPbndx1YlcP3+ 3/cJiv4VydQ+sqSbjfIQdGLziiael2Mv+wuGd1ohuAdZN8cHjZF/Nibg+tvMVHnA GDXCst88mpHqByshyLLWedGMSVVTdayObE54x5vOAJOXu69kEuli0Xb0zhNr1o/k 90XB9QmU7Tkbx33XQGVCmyAWr5ZGyj677DDffQDgJMfpikHHwL9/S+LC3V7T5cK5 L8I99Y2izHJZGFdPaG6Wn/U0B2yXHSPVC8zuyBeTYZ4Qnj4lRcee/bIovM40PjYH QuVhGiKQ7y+L67Xf2chiWVvk4fme11/Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=vEQSr42CnQBUPKCEu b5pbkgSu3hQM6IuMYKUXjZSfOA=; b=ZRY3yz/787epA1/a3xYojUHyGMSrgwPSn 1se3LMK08iu9I1sfdekHnheEDKGXfVY+WFDQ2QNAnQxFkGZa12DYnfrWfRxXz1O+ OZHc86DAkCSRNP2vMfiovNm0oiRZzDsG9f9cm4+kjN8wKuPmos+U9VJ6ZojyTKRp EnYVfCLpX0J+lJsD4pxpJvRfvkz/ZLJzvqmVbDyvgsO0tnFu4Tlv3m7hKTt2Diy4 mRwTwPIqJJGQeueMcFso9jHLbWv2ekvJIulL22JxEi0NMfYGNEuX9LUV3C0GVF1B N3m1VhuArGkVGxppFGo8gXetYo6BRM4ekIcbEw7QXEDVK226ytC/Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeggedgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttdejnecuhfhrohhmpeffrghfnhgr ucfjihhrshgthhhfvghlugcuoegurghfnhgrsehfrghsthhmrghilhdrtghomheqnecugg ftrfgrthhtvghrnhepffelvddujefgieetvdelveetudeukeektdejvdegvdfgudelteff ueejvdevkeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepuggrfhhnrgesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 22 Mar 2022 00:12:59 -0400 (EDT) Date: Tue, 22 Mar 2022 06:12:57 +0200 From: Dafna Hirschfeld To: Laurent Pinchart Cc: linux-media@vger.kernel.org, Heiko Stuebner , Paul Elder , Tomasz Figa , linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3.1 13/17] media: rkisp1: Compile debugfs support conditionally Message-ID: <20220322041257.5mdj5zc7ajgtteor@guri> References: <20220319163100.3083-14-laurent.pinchart@ideasonboard.com> <20220321124437.12749-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220321124437.12749-1-laurent.pinchart@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220321_211302_534821_B4C1BFBE X-CRM114-Status: GOOD ( 12.99 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 21.03.2022 14:44, Laurent Pinchart wrote: > When CONFIG_DEBUGFS is disabled, there's no need to compile the debugfs > support in. Make it conditional. > > Signed-off-by: Laurent Pinchart Reviewed-by: Dafna Hirschfeld > --- > Changes since v3: > > - Fix double mention of rkisp1-debug.o in Makefile > --- > .../media/platform/rockchip/rkisp1/Makefile | 18 ++++++++++-------- > .../platform/rockchip/rkisp1/rkisp1-common.h | 9 +++++++++ > 2 files changed, 19 insertions(+), 8 deletions(-) > > diff --git a/drivers/media/platform/rockchip/rkisp1/Makefile b/drivers/media/platform/rockchip/rkisp1/Makefile > index 1a39bdcc608e..f7543a82aa10 100644 > --- a/drivers/media/platform/rockchip/rkisp1/Makefile > +++ b/drivers/media/platform/rockchip/rkisp1/Makefile > @@ -1,11 +1,13 @@ > # SPDX-License-Identifier: GPL-2.0 > > +rockchip-isp1-y := rkisp1-capture.o \ > + rkisp1-common.o \ > + rkisp1-dev.o \ > + rkisp1-isp.o \ > + rkisp1-resizer.o \ > + rkisp1-stats.o \ > + rkisp1-params.o > + > +rockchip-isp1-$(CONFIG_DEBUG_FS) += rkisp1-debug.o > + > obj-$(CONFIG_VIDEO_ROCKCHIP_ISP1) += rockchip-isp1.o > -rockchip-isp1-objs += rkisp1-capture.o \ > - rkisp1-common.o \ > - rkisp1-debug.o \ > - rkisp1-dev.o \ > - rkisp1-isp.o \ > - rkisp1-resizer.o \ > - rkisp1-stats.o \ > - rkisp1-params.o > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h > index 07a92ed8bdc8..a7ffe2830fa8 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h > @@ -518,7 +518,16 @@ void rkisp1_stats_unregister(struct rkisp1_device *rkisp1); > int rkisp1_params_register(struct rkisp1_device *rkisp1); > void rkisp1_params_unregister(struct rkisp1_device *rkisp1); > > +#if IS_ENABLED(CONFIG_DEBUG_FS) > void rkisp1_debug_init(struct rkisp1_device *rkisp1); > void rkisp1_debug_cleanup(struct rkisp1_device *rkisp1); > +#else > +static inline void rkisp1_debug_init(struct rkisp1_device *rkisp1) > +{ > +} > +static inline void rkisp1_debug_cleanup(struct rkisp1_device *rkisp1) > +{ > +} > +#endif > > #endif /* _RKISP1_COMMON_H */ > -- > Regards, > > Laurent Pinchart > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip