Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support

Sascha Hauer
2022-04-08T12:35:56Z

On Fri, Apr 08, 2022 at 10:07:48AM +0200, Sascha Hauer wrote:
> On Wed, Apr 06, 2022 at 11:47:22AM +0200, Piotr Oniszczuk wrote:
> >
> >
> > > Wiadomość napisana przez Piotr Oniszczuk <piotr.oniszczuk@gmail.com> w dniu 01.04.2022, o godz. 15:05:
> > > Sascha
> > >
> > > Now works perfectly!
> > > (hd playback with 3.5...5.5% cpu while rendering to drm plane)
> > >
> > > Fantastic work of You!
> >
> > Sascha,
> >
> > Having vop2 finally working with drm planes rendering i discovered another issue: overlay osd is invisible at playback.
> >
> > context: player draws video on plane #X and osd on overlay plane #Y
> > When user do i.e. seek at playback - app uses overlay OSD plane to display OSD to user. This approach is used by majority of players (KODI, etc.)
> >
> > This works well on all platforms i have - except rk3566
> >
> > For me it looks like z-order vop2 issue or alpha blending issue.
> > As this is only on rk3566 and only on drm-planes mode - issue is vop2 related imho.
>
> That turned out to be simpler than I thought it would be. The zpos
> values were never actually written to the hardware. Please try the
> following fixup, it should fix this issue.

Or better try v10 which I have just sent.

Sascha

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |