Re: [PATCH v3 10/19] dt-bindings: clock: rockchip: Document RV1126 CRU

Stephen Boyd
2022-08-18T21:29:43Z

Quoting Jagan Teki (2022-08-18 05:41:23)
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + const: xin24m
> +
> + rockchip,grf:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description:
> + Phandle to the syscon managing the "general register files" (GRF),
> + if missing pll rates are not changeable, due to the missing pll
> + lock status.
> +
> +required:
> + - compatible
> + - reg
> + - "#clock-cells"
> + - "#reset-cells"

Why aren't clocks required?

> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + cru: clock-controller@ff490000 {
> + compatible = "rockchip,rv1126-cru";
> + reg = <0xff490000 0x1000>;
> + rockchip,grf = <&grf>;
> + #clock-cells = <1>;
> + #reset-cells = <1>;

Can you add 'clocks' property to the binding?