Re: [PATCH 5/8] ASoC: rockchip: i2s-tdm: Fix clk_id usage in .set_sysclk()

Mark Brown
2022-09-08T16:36:58Z

[-- Attachment #1.1: Type: text/plain, Size: 925 bytes --]

On Wed, Sep 07, 2022 at 04:21:21PM +0200, luca.ceresoli@bootlin.com wrote:

> -static int rockchip_i2s_tdm_set_sysclk(struct snd_soc_dai *cpu_dai, int stream,
> +static int rockchip_i2s_tdm_set_sysclk(struct snd_soc_dai *cpu_dai, int clk_id,
> unsigned int freq, int dir)
> {
> struct rk_i2s_tdm_dev *i2s_tdm = to_info(cpu_dai);
> @@ -978,15 +981,18 @@ static int rockchip_i2s_tdm_set_sysclk(struct snd_soc_dai *cpu_dai, int stream,
> if (i2s_tdm->clk_trcm) {
> i2s_tdm->mclk_tx_freq = freq;
> i2s_tdm->mclk_rx_freq = freq;
> +
> + dev_dbg(i2s_tdm->dev, "mclk freq: %u", freq);
> } else {
> - if (stream == SNDRV_PCM_STREAM_PLAYBACK)
> + if (clk_id == CLK_IDX_MCLK_TX)
> i2s_tdm->mclk_tx_freq = freq;
> - else
> + else if (clk_id == CLK_IDX_MCLK_RX)
> i2s_tdm->mclk_rx_freq = freq;
> - }
> + else
> + return -ENOTSUPP;

This should be a switch statement for clarity and exensibility.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]