From: Jianqun Xu <jay.xu@rock-chips.com>
To: linus.walleij@linaro.org, heiko@sntech.de, brgl@bgdev.pl,
andriy.shevchenko@linux.intel.com
Cc: robert.moore@intel.com, robh@kernel.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
lenb@kernel.org, rafael@kernel.org,
Jianqun Xu <jay.xu@rock-chips.com>
Subject: [PATCH 08/20] gpiolib: make gpiochip_find_by_name to be common function
Date: Tue, 20 Sep 2022 18:30:56 +0800 [thread overview]
Message-ID: <20220920103108.23074-9-jay.xu@rock-chips.com> (raw)
In-Reply-To: <20220920103108.23074-1-jay.xu@rock-chips.com>
Move find_chip_by_name from gpiolib to the gpio/driver.h, also rename to
gpiochip_find_by_name, make it to be a common function.
Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
---
drivers/gpio/gpiolib.c | 16 ++--------------
include/linux/gpio/driver.h | 12 ++++++++++++
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index cc9c0a12259e..c06334772c47 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -935,18 +935,6 @@ struct gpio_chip *gpiochip_find(void *data,
}
EXPORT_SYMBOL_GPL(gpiochip_find);
-static int gpiochip_match_name(struct gpio_chip *gc, void *data)
-{
- const char *name = data;
-
- return !strcmp(gc->label, name);
-}
-
-static struct gpio_chip *find_chip_by_name(const char *name)
-{
- return gpiochip_find((void *)name, gpiochip_match_name);
-}
-
#ifdef CONFIG_GPIOLIB_IRQCHIP
/*
@@ -3660,7 +3648,7 @@ void gpiod_add_hogs(struct gpiod_hog *hogs)
* The chip may have been registered earlier, so check if it
* exists and, if so, try to hog the line now.
*/
- gc = find_chip_by_name(hog->chip_label);
+ gc = gpiochip_find_by_name(hog->chip_label);
if (gc)
gpiochip_machine_hog(gc, hog);
}
@@ -3745,7 +3733,7 @@ static struct gpio_desc *gpiod_find(struct device *dev, const char *con_id,
return ERR_PTR(-EPROBE_DEFER);
}
- gc = find_chip_by_name(p->key);
+ gc = gpiochip_find_by_name(p->key);
if (!gc) {
/*
diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index 6aeea1071b1b..4ed26a7d98ff 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -618,6 +618,18 @@ extern int devm_gpiochip_add_data_with_key(struct device *dev, struct gpio_chip
extern struct gpio_chip *gpiochip_find(void *data,
int (*match)(struct gpio_chip *gc, void *data));
+static int gpiochip_match_name(struct gpio_chip *gc, void *data)
+{
+ const char *name = data;
+
+ return !strcmp(gc->label, name);
+}
+
+static inline struct gpio_chip *gpiochip_find_by_name(const char *name)
+{
+ return gpiochip_find((void *)name, gpiochip_match_name);
+}
+
bool gpiochip_line_is_irq(struct gpio_chip *gc, unsigned int offset);
int gpiochip_reqres_irq(struct gpio_chip *gc, unsigned int offset);
void gpiochip_relres_irq(struct gpio_chip *gc, unsigned int offset);
--
2.25.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2022-09-20 10:32 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 10:30 [PATCH 00/20] Rockchip pinctrl/GPIO support ACPI Jianqun Xu
2022-09-20 10:30 ` [PATCH 01/20] ACPI: utils: Add acpi_dev_uid_to_integer() helper to get _UID as integer Jianqun Xu
2022-09-20 10:30 ` [PATCH 02/20] pinctrl/rockchip: populate GPIO platform early Jianqun Xu
2022-09-20 10:30 ` [PATCH 03/20] pinctrl/rockchip: use fwnode instead of of_node Jianqun Xu
2022-09-20 10:30 ` [PATCH 04/20] pinctrl/rockchip: switch to use device_get_match_data Jianqun Xu
2022-10-04 7:13 ` Linus Walleij
2022-09-20 10:30 ` [PATCH 05/20] pinctrl/rockchip: of_populate_platform for gpio only for of node Jianqun Xu
2022-09-20 10:30 ` [PATCH 06/20] pinctrl/rockchip: parse dt only if the fwnode is " Jianqun Xu
2022-09-20 10:30 ` [PATCH 07/20] pinctrl/rockchip: print a message if driver probed successfully Jianqun Xu
2022-09-20 10:30 ` Jianqun Xu [this message]
2022-09-20 10:30 ` [PATCH 09/20] gpio/rockchip: drop 'bank->name' from the driver Jianqun Xu
2022-09-20 10:30 ` [PATCH 10/20] gpio/rockchip: revert deferred output settings on probe Jianqun Xu
2022-09-20 10:30 ` [PATCH 11/20] gpio/rockchip: add of_node for gpiochip Jianqun Xu
2022-10-04 7:14 ` Linus Walleij
2022-10-04 8:30 ` Andy Shevchenko
2022-10-04 9:06 ` Linus Walleij
2022-10-08 6:19 ` jay.xu
2022-10-08 18:21 ` Andy Shevchenko
2022-09-20 10:31 ` [PATCH 12/20] gpio/rockchip: add return check for clock rate set Jianqun Xu
2022-09-30 9:17 ` Bartosz Golaszewski
2022-09-30 9:28 ` Bartosz Golaszewski
2022-09-20 10:31 ` [PATCH 13/20] gpio/rockchip: disable and put clocks when remove Jianqun Xu
2022-09-30 9:23 ` Bartosz Golaszewski
2022-09-20 10:31 ` [PATCH 14/20] gpio/rockchip: switch to use irq_domain_create_linear Jianqun Xu
2022-09-20 10:31 ` [PATCH 15/20] gpio/rockchip: disable and put clocks when gpiolib register failed Jianqun Xu
2022-10-04 7:16 ` Linus Walleij
2022-10-04 7:16 ` Linus Walleij
2022-09-20 10:31 ` [PATCH 16/20] gpio/rockchip: try to get gpio id from uid when ACPI enabled Jianqun Xu
2022-09-20 10:31 ` [PATCH 17/20] gpio/rockchip: print device with fwnode name when probe successful Jianqun Xu
2022-09-30 9:21 ` Bartosz Golaszewski
2022-09-20 10:31 ` [PATCH 18/20] gpio/rockchip: make use of device property Jianqun Xu
2022-09-20 10:31 ` [PATCH 19/20] gpio/rockchip: make GPIO module work well under ACPI enabled Jianqun Xu
2022-09-20 10:31 ` [PATCH 20/20] pinctrl/rockchip: find existed gpiochip by gpio label Jianqun Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920103108.23074-9-jay.xu@rock-chips.com \
--to=jay.xu@rock-chips.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=heiko@sntech.de \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox