From: "jay.xu@rock-chips.com" <jay.xu@rock-chips.com>
To: "Heiko Stübner" <heiko@sntech.de>,
"linus.walleij" <linus.walleij@linaro.org>
Cc: "Johan Jonker" <jbx6244@gmail.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
linux-gpio <linux-gpio@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>
Subject: Re: Re: [PATCH v2 RESEND 0/2] rockchip pinctrl for acpi
Date: Fri, 23 Sep 2022 18:35:36 +0800 [thread overview]
Message-ID: <202209231835365953827@rock-chips.com> (raw)
In-Reply-To: 2419940.Icojqenx9y@phil
Hi heiko
--------------
jay.xu@rock-chips.com
>Am Dienstag, 20. September 2022, 11:26:26 CEST schrieb Linus Walleij:
>> On Sat, Sep 17, 2022 at 8:09 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:
>>
>> > These patch fixes to support acpi by:
>> > 1. populate gpio platform before pinctrl to probe
>> > 2. get gpiochip by finding from gpiochip list
>> > 3. get match data by device api
>> >
>> > Jianqun Xu (2):
>> > pinctrl: rockchip: find gpiochip by name from gpio module
>> > pinctrl: rockchip: get match data by device_get_match_data
>>
>> These look OK to me but I would feel better if Heiko or Andy ACK:ed
>> them so I give them a few more days to comment.
>
>Right now I'm actually quite confused as I seem to have a bunch
>of pinctrl/gpio-acpi patchsets of varying lengths in my inbox.
>
>There is a "v2", a "v8", a 20-patchset without version.
>It's all quite confusing.
>
From v2 to v8, I summit fixes in one patch, and them sugguested by Andy, I try to separate them
into small patches 20-patchset.
The heart change is
current
1. pinctrl register first
2. gpiochip register and find pinctrl device to add pin range
this patch fix to
1. gpiochip register itself
2. pinctrl register and find all gpiochips and add pin range
Please help to review directly to 20-patchset, I will add some suggested-by and acked-by later
>
>Heiko
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2022-09-23 10:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 6:09 [PATCH v2 RESEND 0/2] rockchip pinctrl for acpi Jianqun Xu
2022-09-17 6:09 ` [PATCH v2 1/2] pinctrl: rockchip: find gpiochip by name from gpio module Jianqun Xu
2022-09-17 6:09 ` [PATCH v2 2/2] pinctrl: rockchip: get match data by device_get_match_data Jianqun Xu
2022-09-20 9:26 ` [PATCH v2 RESEND 0/2] rockchip pinctrl for acpi Linus Walleij
2022-09-23 10:26 ` Heiko Stuebner
2022-09-23 10:33 ` Andy Shevchenko
2022-09-23 10:35 ` jay.xu [this message]
2022-09-23 10:50 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202209231835365953827@rock-chips.com \
--to=jay.xu@rock-chips.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox