Hi Benjamin, I love your patch! Yet something to improve: [auto build test ERROR on media-tree/master] [also build test ERROR on rockchip/for-next linus/master v6.2-rc2 next-20221226] [cannot apply to pza/reset/next pza/imx-drm/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Benjamin-Gaignard/dt-bindings-media-rockchip-vpu-Add-rk3588-vpu-compatible/20230104-010906 base: git://linuxtv.org/media_tree.git master patch link: https://lore.kernel.org/r/20230103170058.810597-8-benjamin.gaignard%40collabora.com patch subject: [PATCH v2 07/13] media: verisilicon: Check AV1 bitstreams bit depth config: riscv-randconfig-r006-20230103 compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 7a8cb6cd4e3ff8aaadebff2b9d3ee9e2a326d444) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/e7673f182caea24871db793ac95b666468cf58bb git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Benjamin-Gaignard/dt-bindings-media-rockchip-vpu-Add-rk3588-vpu-compatible/20230104-010906 git checkout e7673f182caea24871db793ac95b666468cf58bb # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/media/platform/verisilicon/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/media/platform/verisilicon/hantro_drv.c:342:3: error: expected expression int bit_depth = ctrl->p_new.p_av1_sequence->bit_depth; ^ >> drivers/media/platform/verisilicon/hantro_drv.c:345:26: error: use of undeclared identifier 'bit_depth' if (ctx->bit_depth != bit_depth) ^ drivers/media/platform/verisilicon/hantro_drv.c:348:20: error: use of undeclared identifier 'bit_depth' ctx->bit_depth = bit_depth; ^ drivers/media/platform/verisilicon/hantro_drv.c:1039:46: warning: implicit conversion from 'unsigned long long' to 'unsigned int' changes value from 18446744073709551615 to 4294967295 [-Wconstant-conversion] vb2_dma_contig_set_max_seg_size(&pdev->dev, DMA_BIT_MASK(32)); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~ include/linux/dma-mapping.h:76:40: note: expanded from macro 'DMA_BIT_MASK' #define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1)) ^~~~~ 1 warning and 3 errors generated. Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for IOMMU_IO_PGTABLE_LPAE Depends on [n]: IOMMU_SUPPORT [=y] && (ARM || ARM64 || COMPILE_TEST [=y] && !GENERIC_ATOMIC64 [=y]) Selected by [y]: - IPMMU_VMSA [=y] && IOMMU_SUPPORT [=y] && (ARCH_RENESAS [=y] || COMPILE_TEST [=y] && !GENERIC_ATOMIC64 [=y]) vim +342 drivers/media/platform/verisilicon/hantro_drv.c 332 333 static int hantro_av1_s_ctrl(struct v4l2_ctrl *ctrl) 334 { 335 struct hantro_ctx *ctx; 336 337 ctx = container_of(ctrl->handler, 338 struct hantro_ctx, ctrl_handler); 339 340 switch (ctrl->id) { 341 case V4L2_CID_STATELESS_AV1_SEQUENCE: > 342 int bit_depth = ctrl->p_new.p_av1_sequence->bit_depth; 343 344 if (vb2_is_streaming(v4l2_m2m_get_src_vq(ctx->fh.m2m_ctx))) > 345 if (ctx->bit_depth != bit_depth) 346 return -EINVAL; 347 348 ctx->bit_depth = bit_depth; 349 break; 350 default: 351 return -EINVAL; 352 } 353 354 return 0; 355 } 356 -- 0-DAY CI Kernel Test Service https://01.org/lkp