Re: [PATCH v2 1/2] dt-bindings: usb: snps,dwc3: Allow power-domains property

[Thinh Nguyen <Thinh.Nguyen@synopsys.com>]

On Wed, Jan 18, 2023, Rob Herring wrote:
> The Rockchip RK3399 DWC3 node has 'power-domains' property which isn't
> allowed by the schema:
> 
> usb@fe900000: Unevaluated properties are not allowed ('power-domains' was unexpected)
> 
> Allow DWC3 nodes to have a power-domains entry. We could instead move
> the power-domains property to the parent wrapper node, but the could be
> an ABI break (Linux shouldn't care). Also, we don't want to encourage
> the pattern of wrapper nodes just to define resources such as clocks,
> resets, power-domains, etc. when not necessary.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v2:
>  - Allow 2 power domains and explain what they are
> ---
>  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> index 6d78048c4613..be36956af53b 100644
> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> @@ -91,6 +91,16 @@ properties:
>          - usb2-phy
>          - usb3-phy
>  
> +  power-domains:
> +    description:
> +      The DWC3 has 2 power-domains. The power management unit (PMU) and
> +      everything else. The PMU is typically always powered and may not have an
> +      entry.
> +    minItems: 1
> +    items:
> +      - description: Core
> +      - description: Power management unit
> +
>    resets:
>      minItems: 1
>  
> -- 
> 2.39.0
> 

Reviewed-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>

Thanks,
Thinh
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip