From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D195C64EC4 for ; Fri, 17 Feb 2023 11:06:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M4ISc2N7M9ZRwzRZYIJBNwkrNPhuhbYEVGFtkWJNUUw=; b=qPG8W9Rbp7zfef lRRy16gmBv8kJSynuy3PaIDPJOPcB03GJbA9XwZZSZlh3SgXJtz6h37q08TV+5A+om7OUdsVOFaiq YrsWc26ymrcDNisK84oNC6xcvjYy7zp9tyw9gxVgg+c/gUsEMnrVEvBdy99Ad8nSO+ESfdAM7BqAA +P9HH6Xg8dI1EvHFSJZNlFBUlz32G005uTiIVPC7TA8LN00hBiRfbNuBqVjutJ22BrQCHmJLH7u4n C3PKNkauZiNJqarArMQca9O9yP9S9W3NtN0O8hi9RN7tFUAPzQkkbtDCq0WaOVZ8Aj0LjHX2j8b2F +1jF/n/VgZZHyA7hPd3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSyZD-00Dpjp-1O; Fri, 17 Feb 2023 11:06:15 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSyYJ-00DpJm-Vu for linux-rockchip@lists.infradead.org; Fri, 17 Feb 2023 11:05:21 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pSyXL-0002Zy-1G; Fri, 17 Feb 2023 12:04:19 +0100 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pSyXF-0007Ep-HE; Fri, 17 Feb 2023 12:04:13 +0100 Date: Fri, 17 Feb 2023 12:04:13 +0100 From: Michael Tretter To: Shengyu Qu Cc: devicetree@vger.kernel.org, ezequiel@vanguardiasur.com.ar, frattaroli.nicolas@gmail.com, heiko@sntech.de, jacob-chen@iotwrt.com, krzysztof.kozlowski+dt@linaro.org, krzysztof.kozlowski@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, mchehab@kernel.org, robh+dt@kernel.org, kernel@pengutronix.de Subject: Re: [PATCH RESEND 2/2] arm64: dts: rockchip: Add RGA2 support to rk356x Message-ID: <20230217110413.GA28242@pengutronix.de> Mail-Followup-To: Michael Tretter , Shengyu Qu , devicetree@vger.kernel.org, ezequiel@vanguardiasur.com.ar, frattaroli.nicolas@gmail.com, heiko@sntech.de, jacob-chen@iotwrt.com, krzysztof.kozlowski+dt@linaro.org, krzysztof.kozlowski@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, mchehab@kernel.org, robh+dt@kernel.org, kernel@pengutronix.de References: <20230119-rk3568-rga-v1-2-43d4d14365e6@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-rockchip@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230217_030520_055308_5FC55BBE X-CRM114-Status: GOOD ( 13.11 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi, On Sun, 22 Jan 2023 00:50:37 +0800, Shengyu Qu wrote: > Since we have the over-4GB problem now, should we mark this problem as a > TODO or something? I am not really sure where to put such a TODO to make it visible for people that are running into the issue and to make sure that it is removed once it is fixed. Maybe it would be better to add error handling to the rga_buf_map function to fail if the address of the buffer that should be mapped has the upper 32 bit set and print a warning. Furthermore, the driver would be able to skip the buffer and prevent potential memory corruption caused by the erroneous mapping. Unfortunately, I don't have hardware that allows me to test this. Michael _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip