From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: dri-devel@lists.freedesktop.org,
"Sandy Huang" <hjc@rock-chips.com>,
linux-rockchip@lists.infradead.org, kernel@pengutronix.de,
"Chris Morgan" <macroalpha82@gmail.com>,
"Köry Maincent" <kory.maincent@bootlin.com>,
"Michael Riesch" <michael.riesch@wolfvision.net>,
"Paul Kocialkowski" <paul.kocialkowski@bootlin.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] drm/rockchip: vop2: fix suspend/resume
Date: Mon, 17 Apr 2023 14:38:48 +0200 [thread overview]
Message-ID: <20230417123848.GN15436@pengutronix.de> (raw)
In-Reply-To: <7404631.18pcnM708K@diego>
On Mon, Apr 17, 2023 at 12:46:05PM +0200, Heiko Stübner wrote:
> Hi Sascha,
>
> Am Montag, 17. April 2023, 11:42:15 CEST schrieb Sascha Hauer:
> > During a suspend/resume cycle the VO power domain will be disabled and
> > the VOP2 registers will reset to their default values. After that the
> > cached register values will be out of sync and the read/modify/write
> > operations we do on the window registers will result in bogus values
> > written. Fix this by marking the regcache as dirty each time we disable
> > the VOP2 and call regcache_sync() each time we enable it again. With
> > this the VOP2 will show a picture after a suspend/resume cycle whereas
> > without this the screen stays dark.
> >
> > Fixes: 604be85547ce4 ("drm/rockchip: Add VOP2 driver")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>
> somehow we overlapped with this v2 and me applying the original one [0]
> to drm-misc. With drm-misc being a shared tree there is also no way back.
>
> So if this v2 is better suited, could do a follow-up patch instead - on
> top of your original one?
Alright, just did that. You should find it in your inbox.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2023-04-17 12:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 9:42 [PATCH] drm/rockchip: vop2: fix suspend/resume Sascha Hauer
2023-04-17 10:46 ` Heiko Stübner
2023-04-17 12:38 ` Sascha Hauer [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-04-13 14:43 Sascha Hauer
2023-04-13 15:27 ` Chris Morgan
2023-04-14 14:20 ` Paul Kocialkowski
2023-04-17 9:45 ` Sascha Hauer
2023-04-17 10:43 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230417123848.GN15436@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=kernel@pengutronix.de \
--cc=kory.maincent@bootlin.com \
--cc=linux-rockchip@lists.infradead.org \
--cc=macroalpha82@gmail.com \
--cc=michael.riesch@wolfvision.net \
--cc=paul.kocialkowski@bootlin.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox