From: Andy Yan <andyshrk@163.com>
To: heiko@sntech.de
Cc: hjc@rock-chips.com, dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, sebastian.reichel@collabora.com,
kever.yang@rock-chips.com, chris.obbard@collabora.com,
Andy Yan <andy.yan@rock-chips.com>,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: [PATCH v3 04/14] drm/rockchip: vop2: clear afbc en and transform bit for cluster window at linear mode
Date: Thu, 30 Nov 2023 20:23:15 +0800 [thread overview]
Message-ID: <20231130122315.12954-1-andyshrk@163.com> (raw)
In-Reply-To: <20231130122001.12474-1-andyshrk@163.com>
From: Andy Yan <andy.yan@rock-chips.com>
The enable bit and transform offset of cluster windows should be
cleared when it work at linear mode, or we may have a iommu fault
issue on rk3588 which cluster windows switch between afbc and linear
mode.
As the cluster windows of rk3568 only supports afbc format
so is therefore not affected.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
---
(no changes since v1)
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
index 639dfebc6bd1..a019cc9bbd54 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
@@ -1312,6 +1312,11 @@ static void vop2_plane_atomic_update(struct drm_plane *plane,
vop2_win_write(win, VOP2_WIN_AFBC_ROTATE_270, rotate_270);
vop2_win_write(win, VOP2_WIN_AFBC_ROTATE_90, rotate_90);
} else {
+ if (vop2_cluster_window(win)) {
+ vop2_win_write(win, VOP2_WIN_AFBC_ENABLE, 0);
+ vop2_win_write(win, VOP2_WIN_AFBC_TRANSFORM_OFFSET, 0);
+ }
+
vop2_win_write(win, VOP2_WIN_YRGB_VIR, DIV_ROUND_UP(fb->pitches[0], 4));
}
--
2.34.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2023-11-30 12:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 12:20 [PATCH v3 00/14] Add VOP2 support on rk3588 Andy Yan
2023-11-30 12:22 ` [PATCH v3 01/14] drm/rockchip: move output interface related definition to rockchip_drm_drv.h Andy Yan
2023-11-30 12:22 ` [PATCH v3 02/14] Revert "drm/rockchip: vop2: Use regcache_sync() to fix suspend/resume" Andy Yan
2023-11-30 12:23 ` [PATCH v3 03/14] drm/rockchip: vop2: set half_block_en bit in all mode Andy Yan
2023-11-30 12:23 ` Andy Yan [this message]
2023-11-30 12:23 ` [PATCH v3 05/14] drm/rockchip: vop2: Add write mask for VP config done Andy Yan
2023-11-30 12:23 ` [PATCH v3 06/14] drm/rockchip: vop2: Set YUV/RGB overlay mode Andy Yan
2023-11-30 12:23 ` [PATCH v3 07/14] drm/rockchip: vop2: rename grf to sys_grf Andy Yan
2023-11-30 12:24 ` [PATCH v3 08/14] dt-bindings: soc: rockchip: add rk3588 vop/vo syscon Andy Yan
2023-11-30 12:24 ` [PATCH v3 09/14] dt-bindings: display: vop2: Add rk3588 support Andy Yan
2023-12-01 8:17 ` Krzysztof Kozlowski
2023-11-30 12:24 ` [PATCH v3 10/14] dt-bindings: rockchip,vop2: Add more endpoint definition Andy Yan
2023-11-30 12:24 ` [PATCH v3 11/14] drm/rockchip: vop2: Add support for rk3588 Andy Yan
2023-12-05 9:29 ` Sascha Hauer
2023-12-05 9:44 ` Andy Yan
2023-12-05 9:48 ` Sascha Hauer
2023-11-30 12:24 ` [PATCH v3 12/14] drm/rockchip: vop2: Add debugfs support Andy Yan
2023-12-05 9:15 ` Sascha Hauer
2023-12-06 10:20 ` Andy Yan
2023-12-06 11:20 ` Sascha Hauer
2023-12-06 11:27 ` Andy Yan
2023-11-30 12:25 ` [PATCH v3 13/14] dt-bindings: iommu: rockchip: Add Rockchip RK3588 Andy Yan
2023-11-30 22:46 ` Heiko Stübner
2023-11-30 12:25 ` [PATCH v3 14/14] arm64: dts: rockchip: Add vop on rk3588 Andy Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231130122315.12954-1-andyshrk@163.com \
--to=andyshrk@163.com \
--cc=andy.yan@rock-chips.com \
--cc=chris.obbard@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox