Linux-Rockchip Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Shantur Rathore <i@shantur.com>
Cc: devicetree@vger.kernel.org, heiko@sntech.de,
	linux-rockchip@lists.infradead.org, sigmaris@gmail.com,
	dsimic@manjaro.org
Subject: [PATCH v2] dts: rockpro64: Remove usb regulator-always-on
Date: Fri, 22 Dec 2023 14:16:16 +0000	[thread overview]
Message-ID: <20231222141616.508073-1-i@shantur.com> (raw)

USB port regulators should be controlled by PHYs
so we remove always-on property and let PHYs manage the
regulator.

phy-supply isn't sconfugred for the TypeC port and now that we are
removing regulator-always-on, we need to fix the phy-supply
so the PHYs are able to turn power to type-c port.

Series-version: 2

Signed-off-by: Shantur Rathore <i@shantur.com>
---
 arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi
index bca2b50e0a..f7273f7990 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi
@@ -192,7 +192,6 @@ vcc5v0_host: vcc5v0-host-regulator {
 		pinctrl-names = "default";
 		pinctrl-0 = <&vcc5v0_host_en>;
 		regulator-name = "vcc5v0_host";
-		regulator-always-on;
 		vin-supply = <&vcc5v0_usb>;
 	};
 
@@ -203,7 +202,6 @@ vcc5v0_typec: vcc5v0-typec-regulator {
 		pinctrl-names = "default";
 		pinctrl-0 = <&vcc5v0_typec_en>;
 		regulator-name = "vcc5v0_typec";
-		regulator-always-on;
 		vin-supply = <&vcc5v0_usb>;
 	};
 
@@ -859,6 +857,7 @@ &u2phy0 {
 	status = "okay";
 
 	u2phy0_otg: otg-port {
+		phy-supply = <&vcc5v0_typec>;
 		status = "okay";
 	};
 
-- 
2.40.1


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

             reply	other threads:[~2023-12-22 14:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-22 14:16 Shantur Rathore [this message]
2023-12-29 22:08 ` [PATCH v2] dts: rockpro64: Remove usb regulator-always-on Heiko Stübner
2024-01-04  9:44   ` Shantur Rathore
2024-01-04  9:50     ` Dragan Simic
2024-01-08 12:11       ` Shantur Rathore
2024-01-08 12:29         ` Heiko Stübner
2024-01-08 14:47           ` Dragan Simic
2024-01-21 22:12             ` Shantur Rathore
2024-01-21 22:24               ` Dragan Simic
2024-01-21 22:56                 ` Shantur Rathore
2024-01-08 14:40         ` Dragan Simic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231222141616.508073-1-i@shantur.com \
    --to=i@shantur.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dsimic@manjaro.org \
    --cc=heiko@sntech.de \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=sigmaris@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox