From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A61BDC4725D for ; Mon, 22 Jan 2024 12:14:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VuA8OIYBbtXlPnv3sNcMsbDGDcaDzfSv6vfMv7DU6l8=; b=l3jCCXRyIgWpEy jLEVu2Qy2POI1wAmJHy7y+TQEAmoq41MpYulHpBGi4oCVIbKAYR4IUqFYFZpLt4Qv8PPJHUQRM7eO SYbsmcF9sDlugCnIrhd8Q6QDWcGAmeM5spAtvMt9aMOpkZmgvY+/jOqDoUDesY1Wl5o1EDH/urGCV 7I+0l5Fi2aEyB8iG0c6BdZAdiMmSyJ4YtT4ur0a+d4xusCNEiMZUClhhwg2x8VjJQtZq5ScUk4C1K V90ZEz36YekARE6c3XM9S0ZjVcKFxaYC+CDS/65u4w5TiCUnB/Qw0ThGr+rKrxwjhUHEEKj8tCd52 fJ0fCtFtmVzLrrNHTpGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rRtCH-00C317-0l; Mon, 22 Jan 2024 12:14:37 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rRtCE-00C2yq-0L for linux-rockchip@lists.infradead.org; Mon, 22 Jan 2024 12:14:36 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rRtBt-0001Ez-7i; Mon, 22 Jan 2024 13:14:13 +0100 Received: from [2a0a:edc0:2:b01:1d::c0] (helo=ptx.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rRtBp-001al3-I5; Mon, 22 Jan 2024 13:14:09 +0100 Received: from sha by ptx.whiteo.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1rRtBp-001Bwe-En; Mon, 22 Jan 2024 13:14:09 +0100 Date: Mon, 22 Jan 2024 13:14:09 +0100 From: Sascha Hauer To: Cristian Ciocaltea Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Philipp Zabel , Johan Jonker , Sebastian Reichel , Andy Yan , Algea Cao , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH 3/3] phy: rockchip: Add Samsung HDMI/DP Combo PHY driver Message-ID: <20240122121409.GW4700@pengutronix.de> References: <20240119193806.1030214-1-cristian.ciocaltea@collabora.com> <20240119193806.1030214-4-cristian.ciocaltea@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240119193806.1030214-4-cristian.ciocaltea@collabora.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-rockchip@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240122_041434_289487_E307DDF3 X-CRM114-Status: GOOD ( 37.49 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Fri, Jan 19, 2024 at 09:38:03PM +0200, Cristian Ciocaltea wrote: > Add driver for the Rockchip HDMI/eDP TX Combo PHY found on RK3588 SoC. > > The PHY is based on a Samsung IP block and supports HDMI 2.1 TMDS, FRL > and eDP links. The maximum data rate is 12Gbps (HDMI 2.1 FRL), while > the minimum is 250Mbps (HDMI 2.1 TMDS). > > Co-developed-by: Algea Cao > Signed-off-by: Algea Cao > Signed-off-by: Cristian Ciocaltea > --- > drivers/phy/rockchip/Kconfig | 8 + > drivers/phy/rockchip/Makefile | 1 + > .../phy/rockchip/phy-rockchip-samsung-hdptx.c | 2045 +++++++++++++++++ > 3 files changed, 2054 insertions(+) > create mode 100644 drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c > > diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig > index 94360fc96a6f..95666ac6aa3b 100644 > --- a/drivers/phy/rockchip/Kconfig > +++ b/drivers/phy/rockchip/Kconfig > @@ -83,6 +83,14 @@ config PHY_ROCKCHIP_PCIE > help > Enable this to support the Rockchip PCIe PHY. > > +config PHY_ROCKCHIP_SAMSUNG_HDPTX > + tristate "Rockchip Samsung HDMI/DP Combo PHY driver" > + depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF > + select GENERIC_PHY > + help > + Enable this to support the Rockchip HDMI/DP Combo PHY > + with Samsung IP block. > + > config PHY_ROCKCHIP_SNPS_PCIE3 > tristate "Rockchip Snps PCIe3 PHY Driver" > depends on (ARCH_ROCKCHIP && OF) || COMPILE_TEST > diff --git a/drivers/phy/rockchip/Makefile b/drivers/phy/rockchip/Makefile > index 7eab129230d1..3d911304e654 100644 > --- a/drivers/phy/rockchip/Makefile > +++ b/drivers/phy/rockchip/Makefile > @@ -8,6 +8,7 @@ obj-$(CONFIG_PHY_ROCKCHIP_INNO_HDMI) += phy-rockchip-inno-hdmi.o > obj-$(CONFIG_PHY_ROCKCHIP_INNO_USB2) += phy-rockchip-inno-usb2.o > obj-$(CONFIG_PHY_ROCKCHIP_NANENG_COMBO_PHY) += phy-rockchip-naneng-combphy.o > obj-$(CONFIG_PHY_ROCKCHIP_PCIE) += phy-rockchip-pcie.o > +obj-$(CONFIG_PHY_ROCKCHIP_SAMSUNG_HDPTX) += phy-rockchip-samsung-hdptx.o > obj-$(CONFIG_PHY_ROCKCHIP_SNPS_PCIE3) += phy-rockchip-snps-pcie3.o > obj-$(CONFIG_PHY_ROCKCHIP_TYPEC) += phy-rockchip-typec.o > obj-$(CONFIG_PHY_ROCKCHIP_USB) += phy-rockchip-usb.o > diff --git a/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c b/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c > new file mode 100644 > index 000000000000..d8171ea5ce2b > --- /dev/null > +++ b/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c > @@ -0,0 +1,2045 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright (c) 2021-2022 Rockchip Electronics Co., Ltd. > + * Copyright (c) 2024 Collabora Ltd. > + * > + * Author: Algea Cao > + * Author: Cristian Ciocaltea > + */ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#define GRF_HDPTX_CON0 0x00 > +#define HDPTX_I_PLL_EN BIT(7) > +#define HDPTX_I_BIAS_EN BIT(6) > +#define HDPTX_I_BGR_EN BIT(5) > +#define GRF_HDPTX_STATUS 0x80 > +#define HDPTX_O_PLL_LOCK_DONE BIT(3) > +#define HDPTX_O_PHY_CLK_RDY BIT(2) > +#define HDPTX_O_PHY_RDY BIT(1) > +#define HDPTX_O_SB_RDY BIT(0) > + > +#define CMN_REG0000 0x0000 These register names are not particularly helpful. Maybe use a #define CMN_REG(x) ((x) * 4) Instead? > + > +static int hdptx_lcpll_frl_mode_config(struct rockchip_hdptx_phy *hdptx, > + u32 rate) > +{ > + u32 bit_rate = rate & DATA_RATE_MASK; > + u8 color_depth = (rate & COLOR_DEPTH_MASK) ? 1 : 0; > + const struct lcpll_config *cfg = lcpll_cfg; > + > + for (; cfg->bit_rate != ~0; cfg++) > + if (bit_rate == cfg->bit_rate) > + break; You could use ARRAY_SIZE() to iterate over the array and save the extra entry at the end. Likewise for the other arrays used in the driver. > + > + if (cfg->bit_rate == ~0) > + return -EINVAL; > + > +static int rockchip_hdptx_phy_power_on(struct phy *phy) > +{ > + struct rockchip_hdptx_phy *hdptx = phy_get_drvdata(phy); > + int bus_width = phy_get_bus_width(hdptx->phy); > + int bit_rate = bus_width & DATA_RATE_MASK; What is going on here? bus_width is set to 8 in probe() using phy_set_bus_width(), but the value you pull out of phy_get_bus_width() is expected to contain the bit_rate and several other flags. It looks like you are tunneling flags from some other driver using this field. Isn't there a better way to accomplish this? If not, I think this needs some explanation. At least the variable should be renamed. it's called "bus_width" and it's passed to functions like hdptx_lcpll_frl_mode_config() which has this parameter named "rate" which is quite confusing. Sascha > + int ret; > + > + dev_dbg(hdptx->dev, "%s bus_width=%x rate=%d\n", > + __func__, bus_width, bit_rate); > + > + ret = pm_runtime_resume_and_get(hdptx->dev); > + if (ret) { > + dev_err(hdptx->dev, "Failed to resume phy: %d\n", ret); > + return ret; > + } > + > + if (bus_width & HDMI_EARC_MASK) > + hdptx->earc_en = true; > + else > + hdptx->earc_en = false; > + > + if (bus_width & HDMI_MODE_MASK) { > + if (bit_rate > 24000000) > + ret = hdptx_lcpll_frl_mode_config(hdptx, bus_width); > + else > + ret = hdptx_ropll_frl_mode_config(hdptx, bus_width); > + } else { > + ret = hdptx_ropll_tmds_mode_config(hdptx, bus_width); > + } > + > + if (ret) > + pm_runtime_put(hdptx->dev); > + > + return ret; > +} > + -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip