Re: [PATCH v12 2/8] PCI: dwc: ep: Add Kernel-doc comments for APIs

Manivannan Sadhasivam
2024-04-15T14:00:54Z

On Fri, Apr 12, 2024 at 02:58:36PM -0500, Bjorn Helgaas wrote:
> On Wed, Mar 27, 2024 at 02:43:31PM +0530, Manivannan Sadhasivam wrote:
> > All of the APIs are missing the Kernel-doc comments. Hence, add them.
>
> > + * dw_pcie_ep_reset_bar - Reset endpoint BAR
>
> Apparently this resets @bar for every function of the device, so it's
> not just a single BAR?
>

Right. It should've been 'Reset endpoint BARs'. And the API name is also
misleading, but that is not the scope of this series.

> > + * dw_pcie_ep_raise_intx_irq - Raise INTx IRQ to the host
> > + * @ep: DWC EP device
> > + * @func_no: Function number of the endpoint
> > + *
> > + * Return: 0 if success, errono otherwise.
>
> s/errono/errno/ (another instance below)
>

ah, thanks for spotting. Since this series is already merged, I hope Krzysztof
can ammend this.

- Mani

--
மணிவண்ணன் சதாசிவம்