Re: [PATCH v1 5/5] drm/ci: update xfails for the new testlist

Vignesh Raman
2024-05-07T06:07:59Z

Hi Dmitry,

On 30/04/24 15:45, Dmitry Baryshkov wrote:
> On Tue, Apr 30, 2024 at 02:41:21PM +0530, Vignesh Raman wrote:
>> Now the testlist is used from IGT build, so update
>> xfails with the new testlist.
>>
>> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
>> ---
>> .../gpu/drm/ci/xfails/amdgpu-stoney-fails.txt | 47 +++++++----
>> .../drm/ci/xfails/amdgpu-stoney-flakes.txt | 8 +-
>> .../gpu/drm/ci/xfails/amdgpu-stoney-skips.txt | 15 ++++
>> drivers/gpu/drm/ci/xfails/i915-amly-fails.txt | 22 ++++-
>> .../gpu/drm/ci/xfails/i915-amly-flakes.txt | 8 ++
>> drivers/gpu/drm/ci/xfails/i915-amly-skips.txt | 8 ++
>> drivers/gpu/drm/ci/xfails/i915-apl-fails.txt | 45 +++++-----
>> drivers/gpu/drm/ci/xfails/i915-apl-flakes.txt | 5 ++
>> drivers/gpu/drm/ci/xfails/i915-apl-skips.txt | 12 +++
>> drivers/gpu/drm/ci/xfails/i915-cml-fails.txt | 26 +++++-
>> drivers/gpu/drm/ci/xfails/i915-cml-flakes.txt | 6 ++
>> drivers/gpu/drm/ci/xfails/i915-cml-skips.txt | 8 ++
>> drivers/gpu/drm/ci/xfails/i915-glk-fails.txt | 28 +++++--
>> drivers/gpu/drm/ci/xfails/i915-glk-skips.txt | 12 +++
>> drivers/gpu/drm/ci/xfails/i915-kbl-fails.txt | 39 ++++-----
>> drivers/gpu/drm/ci/xfails/i915-kbl-flakes.txt | 10 ++-
>> drivers/gpu/drm/ci/xfails/i915-kbl-skips.txt | 21 +++++
>> drivers/gpu/drm/ci/xfails/i915-tgl-fails.txt | 75 +++++++++--------
>> drivers/gpu/drm/ci/xfails/i915-tgl-skips.txt | 13 +++
>> drivers/gpu/drm/ci/xfails/i915-whl-fails.txt | 46 +++++------
>> drivers/gpu/drm/ci/xfails/i915-whl-skips.txt | 8 ++
>> .../drm/ci/xfails/mediatek-mt8173-fails.txt | 47 +++--------
>> .../drm/ci/xfails/mediatek-mt8183-fails.txt | 17 +---
>> .../drm/ci/xfails/mediatek-mt8183-flakes.txt | 5 ++
>> .../gpu/drm/ci/xfails/meson-g12b-fails.txt | 20 +----
>> .../gpu/drm/ci/xfails/meson-g12b-flakes.txt | 5 ++
>> .../gpu/drm/ci/xfails/msm-apq8016-fails.txt | 26 ++----
>> .../gpu/drm/ci/xfails/msm-apq8016-flakes.txt | 5 ++
>> .../gpu/drm/ci/xfails/msm-apq8096-fails.txt | 5 +-
>> .../gpu/drm/ci/xfails/msm-apq8096-flakes.txt | 5 ++
>> .../gpu/drm/ci/xfails/msm-apq8096-skips.txt | 67 +++++++++++++++
>> .../msm-sc7180-trogdor-kingoftown-fails.txt | 34 ++++----
>> .../msm-sc7180-trogdor-kingoftown-flakes.txt | 5 ++
>> ...sm-sc7180-trogdor-lazor-limozeen-fails.txt | 34 ++++----
>> ...m-sc7180-trogdor-lazor-limozeen-flakes.txt | 5 ++
>> .../gpu/drm/ci/xfails/msm-sdm845-fails.txt | 75 ++++-------------
>> .../gpu/drm/ci/xfails/msm-sdm845-flakes.txt | 26 ++----
>> .../drm/ci/xfails/rockchip-rk3288-fails.txt | 54 ------------
>> .../drm/ci/xfails/rockchip-rk3399-fails.txt | 80 ++----------------
>> .../drm/ci/xfails/rockchip-rk3399-flakes.txt | 7 --
>> .../drm/ci/xfails/virtio_gpu-none-fails.txt | 82 +++++++++++++------
>> .../drm/ci/xfails/virtio_gpu-none-skips.txt | 3 +
>> 42 files changed, 574 insertions(+), 495 deletions(-)
>> create mode 100644 drivers/gpu/drm/ci/xfails/i915-amly-flakes.txt
>> create mode 100644 drivers/gpu/drm/ci/xfails/i915-apl-flakes.txt
>> create mode 100644 drivers/gpu/drm/ci/xfails/i915-cml-flakes.txt
>> create mode 100644 drivers/gpu/drm/ci/xfails/mediatek-mt8183-flakes.txt
>> create mode 100644 drivers/gpu/drm/ci/xfails/meson-g12b-flakes.txt
>> create mode 100644 drivers/gpu/drm/ci/xfails/msm-apq8016-flakes.txt
>> create mode 100644 drivers/gpu/drm/ci/xfails/msm-apq8096-flakes.txt
>> create mode 100644 drivers/gpu/drm/ci/xfails/msm-sc7180-trogdor-kingoftown-flakes.txt
>> create mode 100644 drivers/gpu/drm/ci/xfails/msm-sc7180-trogdor-lazor-limozeen-flakes.txt
>> delete mode 100644 drivers/gpu/drm/ci/xfails/rockchip-rk3288-fails.txt
>> delete mode 100644 drivers/gpu/drm/ci/xfails/rockchip-rk3399-flakes.txt
>>
>
> [skipped]
>
>> diff --git a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>> index 44a5c62dedad..96e9faf0e607 100644
>> --- a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>> +++ b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>> @@ -1,19 +1,9 @@
>> +core_setmaster_vs_auth,Fail
>> +device_reset,Fail
>> +dumb_buffer,Fail
>
> This doesn't look correct, core tests should be passing.
>
>> kms_3d,Fail
>> -kms_addfb_basic@addfb25-bad-modifier,Fail
>> -kms_cursor_legacy@all-pipes-forked-bo,Fail
>> -kms_cursor_legacy@all-pipes-forked-move,Fail
>> -kms_cursor_legacy@all-pipes-single-bo,Fail
>> -kms_cursor_legacy@all-pipes-single-move,Fail
>> -kms_cursor_legacy@all-pipes-torture-bo,Fail
>> -kms_cursor_legacy@all-pipes-torture-move,Fail
>> -kms_cursor_legacy@pipe-A-forked-bo,Fail
>> -kms_cursor_legacy@pipe-A-forked-move,Fail
>> -kms_cursor_legacy@pipe-A-single-bo,Fail
>> -kms_cursor_legacy@pipe-A-single-move,Fail
>> -kms_cursor_legacy@pipe-A-torture-bo,Fail
>> -kms_cursor_legacy@pipe-A-torture-move,Fail
>> -kms_force_connector_basic@force-edid,Fail
>> -kms_hdmi_inject@inject-4k,Fail
>> -kms_selftest@drm_format,Timeout
>> -kms_selftest@drm_format_helper,Timeout
>
> Fine, kms_cursor_legacy tests were migrated to -flakes. But what
> happened with the rest of the failures? >
>> -msm_mapping@ring,Fail
>> +kms_force_connector_basic,Fail
>> +kms_lease,Fail
>> +msm_mapping,Fail
>> +msm_submit,Fail
>> +tools_test,Fail
>> diff --git a/drivers/gpu/drm/ci/xfails/msm-apq8016-flakes.txt b/drivers/gpu/drm/ci/xfails/msm-apq8016-flakes.txt
>> new file mode 100644
>> index 000000000000..3cc361b3d3b3
>> --- /dev/null
>> +++ b/drivers/gpu/drm/ci/xfails/msm-apq8016-flakes.txt
>> @@ -0,0 +1,5 @@
>> +# Board Name: apq8016-sbc-usb-host
>> +# Bug Report: TBD
>> +# IGT Version: 1.28-gd2af13d9f
>> +# Linux Version: 6.9.0-rc4
>> +kms_cursor_legacy
>
> It looks like one of the scripts has lost subtest granularity. It should
> be fixed before the patchset can be merged
I will recheck these files with the script fix. Thanks.

Regards,
Vignesh