Re: [PATCH 3/3] pinctrl: rockchip: add rk3308b SoC support

Dmitry Yashin
2024-05-16T12:07:06Z

Hi Luca,

On 15.05.24 21:29, Luca Ceresoli wrote:
> I'm skeptical about this being bound to a new DT compatible. As far as I
> know the RK3308 and RK3308B are mostly equivalent, so it looks as the
> pinctrl implementation could be detected at runtime. This would let
> products to be built with either chip version and work on any without
> any DT change.

Thanks for your feedback.

Indeed, these SoC's have a lot in common, but as I can see the rk3308b
has more blocks, like extra PWM's (rk3308 datasheet 1.5 [0] shows only
1x PWM 4ch, when rk3308b and rk3308b-s have 3x PWM 4ch), 1-wire and
CAN controller (mentioned in the TRM, but dropped from rk3308b
datasheet for some reason).

So, in my view, it really makes sense to add rk3308b.dtsi, where extra
PWM's, pinctrl compatible and its pin functions can be moved. And if
its not worth it, then I will try to adapt the entire series to runtime
config based on cpuid like you suggested.

Additional thoughts on this would be appreciated.

[0] https://rockchip.fr/RK3308%20datasheet%20V1.5.pdf

--
Thanks,
Dmitry