Re: [PATCH v2 3/4] media: dt-bindings: rockchip: Document RK3588 Video Decoder bindings

Conor Dooley
2024-06-19T17:37:46Z

[-- Attachment #1.1: Type: text/plain, Size: 3007 bytes --]

On Wed, Jun 19, 2024 at 10:57:20AM -0400, Detlev Casanova wrote:
> Document the Rockchip RK3588 Video Decoder bindings.
>
> Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
> ---
> .../bindings/media/rockchip,vdec.yaml | 46 +++++++++++++++++++
> 1 file changed, 46 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> index 08b02ec16755..22cb62faaa9b 100644
> --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> @@ -17,6 +17,7 @@ properties:
> compatible:
> oneOf:
> - const: rockchip,rk3399-vdec
> + - const: rockchip,rk3588-vdec
> - items:
> - enum:
> - rockchip,rk3228-vdec
> @@ -30,29 +31,56 @@ properties:
> maxItems: 1
>
> clocks:
> + minItems: 4
> items:
> - description: The Video Decoder AXI interface clock
> - description: The Video Decoder AHB interface clock
> - description: The Video Decoded CABAC clock
> - description: The Video Decoder core clock
> + - description: The Video decoder HEVC CABAC clock
>
> clock-names:
> + minItems: 4
> items:
> - const: axi
> - const: ahb
> - const: cabac
> - const: core
> + - const: hevc_cabac
>
> assigned-clocks: true
>
> assigned-clock-rates: true
>
> + resets:
> + items:
> + - description: The Video Decoder AXI interface reset
> + - description: The Video Decoder AHB interface reset
> + - description: The Video Decoded CABAC reset
> + - description: The Video Decoder core reset
> + - description: The Video decoder HEVC CABAC reset
> +
> + reset-names:
> + items:
> + - const: rst_axi
> + - const: rst_ahb
> + - const: rst_cabac
> + - const: rst_core
> + - const: rst_hevc_cabac
> +
> power-domains:
> maxItems: 1
>
> iommus:
> maxItems: 1
>
> + sram:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: |
> + phandle to a reserved on-chip SRAM regions.
> + Some SoCs, like rk3588 provide on-chip SRAM to store temporary
> + buffers during decoding.
> +
> required:
> - compatible
> - reg
> @@ -61,6 +89,24 @@ required:
> - clock-names
> - power-domains
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: rockchip,rk3588-vdec
> + then:
> + properties:
> + clocks:
> + minItems: 5
> + clock-names:
> + minItems: 5
> +
> + resets:
> + minItems: 5
> + reset-names:
> + minItems: 5

You need an else clause here to restrict sram, resets on the other
platforms and to cap clocks at maxItems: 4.

Thanks,
Conor.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]