Re: [PATCH v2 2/2] arm64: dts: rockchip: add ROCK 5 ITX board

Heiko Stübner
2024-07-04T10:35:02Z

Am Donnerstag, 4. Juli 2024, 11:55:24 CEST schrieb Heiko Stuebner:
> The ROCK 5 ITX as the name suggests is made in the ITX form factor and
> actually built in a form to be used in a regular case even providing
> connectors for regular front-panel io.
>
> It can be powered either by 12V, ATX power-supply or PoE.
>
> Notable peripherals are the 4 SATA ports, M.2 M-Key slot, M.2 E-key slot,
> 2*2.5Gb PCIe-connected Ethernet NICs.
>
> As of yet unsupported display options consist of 2*HDMI, DP via USB-c,
> eDP + 2*DSI via PCB connectors.
>
> USB ports are 4*USB3 + 2*USB2 on the back panel and 2-port front-panel
> connector.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> .../boot/dts/rockchip/rk3588-rock-5-itx.dts | 1186 +++++++++++++++++
> 2 files changed, 1187 insertions(+)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
>
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index e8eba631da23e..41ee495a91f6b 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -129,6 +129,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-nanopc-t6.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-ok3588-c.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-orangepi-5-plus.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-quartzpro64.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-rock-5-itx.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-rock-5b.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-rock-5b-pcie-ep.dtbo
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-rock-5b-pcie-srns.dtbo
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
> new file mode 100644
> index 0000000000000..605277525a4ad
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
> @@ -0,0 +1,1186 @@

[...]

> +/* FUSB302 and LCD1 connector */
> +&i2c8 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c8m4_xfer>;
> + status = "okay";
> +
> + usbc0: usb-typec@22 {
> + compatible = "fcs,fusb302";
> + reg = <0x22>;
> + interrupt-parent = <&gpio3>;
> + interrupts = <RK_PB4 IRQ_TYPE_LEVEL_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&usbc0_int>;
> + vbus-supply = <&typec_vin>;
> +
> + usb_con: connector {
> + compatible = "usb-c-connector";
> + label = "USB-C";
> + data-role = "dual";
> + power-role = "dual";
> + try-power-role = "sink";
> + op-sink-microwatt = <1000000>;
> + sink-pdos =
> + <PDO_FIXED(5000, 1000, PDO_FIXED_USB_COMM)>;
> + source-pdos =
> + <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>;

as sigmaris noted on IRC:
I think the usb-c-connector on the Rock 5 ITX dts should not be a PD sink.
The schematic from Radxa shows TYPEC_VIN only connected to the output
of regulator U2603, there is no power path I can see for it to power the
board [...] and powering via USB-C isn't mentioned in the other docs

and I'd remove try-power-role and sink-pdos (try-power-role seems
optional if power-role is not dual)

and also remove op-sink-microwatt