Re: [PATCH 1/7] dt-bindings: mfd: add binding for qnap,mcu devices

Krzysztof Kozlowski
2024-07-26T10:04:53Z

On 25/07/2024 21:45, Heiko Stuebner wrote:
> These MCUs can be found in network attached storage devices made by QNAP.
> They are connected to a serial port of the host device and provide
> functionality like LEDs, power-control and temperature monitoring.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> .../devicetree/bindings/mfd/qnap,mcu.yaml | 43 +++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/qnap,mcu.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/qnap,mcu.yaml b/Documentation/devicetree/bindings/mfd/qnap,mcu.yaml
> new file mode 100644
> index 0000000000000..3b1ad8cb54da3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/qnap,mcu.yaml

qnap,ts433-mcu.yaml

> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/qnap,mcu.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: QNAP NAS on-board Microcontroller
> +
> +maintainers:
> + - Heiko Stuebner <heiko@sntech.de>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> + QNAP embeds a microcontroller on their NAS devices adding system feature
> + as PWM Fan control, additional LEDs, power button status and more.
> +

With two above:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof