Re: [PATCH 0/5] Add GameForce Ace

Chris Morgan
2024-07-31T15:32:58Z

On Mon, Jul 29, 2024 at 12:52:50PM -0600, Rob Herring (Arm) wrote:
>
> On Fri, 26 Jul 2024 14:49:43 -0500, Chris Morgan wrote:
> > From: Chris Morgan <macromorgan@hotmail.com>
> >
> > Add support for the GameForce Ace. The GameForce Ace is an RK3588s
> > based gaming device with a 1080p display, touchscreen, hall effect
> > joysticks and triggers, 128GB of eMMC, 8GB or 12GB of RAM, WiFi 5,
> > and support for a 2242 NVME.
> >
> > Chris Morgan (5):
> > dt-bindings: power: supply: add dual-cell for cw2015
> > power: supply: cw2015: Add support for dual-cell configurations
> > arm64: dts: rockchip: Pull up sdio pins on RK3588
> > dt-bindings: arm: rockchip: Add GameForce Ace
> > arm64: dts: rockchip: Add GameForce Ace
> >
> > .../devicetree/bindings/arm/rockchip.yaml | 5 +
> > .../bindings/power/supply/cw2015_battery.yaml | 6 +
> > arch/arm64/boot/dts/rockchip/Makefile | 1 +
> > .../dts/rockchip/rk3588-base-pinctrl.dtsi | 10 +-
> > .../dts/rockchip/rk3588s-gameforce-ace.dts | 1315 +++++++++++++++++
> > drivers/power/supply/cw2015_battery.c | 7 +
> > 6 files changed, 1339 insertions(+), 5 deletions(-)
> > create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dts
> >
> > --
> > 2.34.1
> >
> >
> >
>
>
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
>
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
>
> pip3 install dtschema --upgrade
>
>
> New warnings running 'make CHECK_DTBS=y rockchip/rk3588s-gameforce-ace.dtb' for 20240726194948.109326-1-macroalpha82@gmail.com:
>
> arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dtb: typec-portc@22: 'vbus-supply' is a required property
> from schema $id: http://devicetree.org/schemas/usb/fcs,fusb302.yaml#
>

For the moment this is expected, because the regulator is driven by a
TI BQ25703 chip that I'm still working on getting supported. Is it
preferable to either keep it empty (and cause this error) or fill it
with a dummy regulator for now?

Thank you.