Re: [PATCH 3/5] arm64: dts: rockchip: Pull up sdio pins on RK3588

Heiko Stübner
2024-07-26T21:42:45Z

Am Freitag, 26. Juli 2024, 21:49:46 CEST schrieb Chris Morgan:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> When using an Ampak derived bcm43456 on an RK3588s based GameForce Ace
> the WiFi failed to work properly until I set the SDIO pins from
> pull-none to pull-up. This matches the vendor kernel located at [1].
> I tested this then on an RK3588s based Indiedroid Nova and did not
> observe any adverse effects.
>
> [1] https://github.com/rockchip-linux/kernel/commit/b96485b7af46a99c14f3c4818eb18c7836eb809c

As you're essentially duplicating the change by Alex Zhao it might be
nice to keep their authorship?

So, "From" + first Signed-off from Alex, then you add a
[adapted to pinctrl filename change]
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>

below that.

>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi
> index 30db12c4fc82..d1368418502a 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi
> @@ -2449,15 +2449,15 @@ sdiom1_pins: sdiom1-pins {
> /* sdio_clk_m1 */
> <3 RK_PA5 2 &pcfg_pull_none>,
> /* sdio_cmd_m1 */
> - <3 RK_PA4 2 &pcfg_pull_none>,
> + <3 RK_PA4 2 &pcfg_pull_up>,
> /* sdio_d0_m1 */
> - <3 RK_PA0 2 &pcfg_pull_none>,
> + <3 RK_PA0 2 &pcfg_pull_up>,
> /* sdio_d1_m1 */
> - <3 RK_PA1 2 &pcfg_pull_none>,
> + <3 RK_PA1 2 &pcfg_pull_up>,
> /* sdio_d2_m1 */
> - <3 RK_PA2 2 &pcfg_pull_none>,
> + <3 RK_PA2 2 &pcfg_pull_up>,
> /* sdio_d3_m1 */
> - <3 RK_PA3 2 &pcfg_pull_none>;
> + <3 RK_PA3 2 &pcfg_pull_up>;
> };
> };