From: Chukun Pan <amadeus@jmu.edu.cn>
To: bigfoot@classfun.cn
Cc: amadeus@jmu.edu.cn, conor+dt@kernel.org,
devicetree@vger.kernel.org, dsimic@manjaro.org, heiko@sntech.de,
jonas@kwiboo.se, krzk+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568
Date: Fri, 6 Sep 2024 16:10:05 +0800 [thread overview]
Message-ID: <20240906081005.69334-1-amadeus@jmu.edu.cn> (raw)
In-Reply-To: <20240906045706.1004813-4-bigfoot@classfun.cn>
Hi Junhao,
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
> @@ -0,0 +1,595 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/leds/common.h>
> +#include <dt-bindings/pinctrl/rockchip.h>
> +#include <dt-bindings/soc/rockchip,vop2.h>
> +#include <dt-bindings/soc/rockchip,boot-mode.h>
No need for input.h, leds/common.h and boot-mode.h.
> +#include "rk3568.dtsi"
> ...
> + vcc3v3_sd: regulator-3v3-vcc-sd {
> + pinctrl-0 = <&vcc_sd_h>;
schematics: sdmmc0_pwren
> ...
> + vcc3v3_rf: regulator-3v3-vcc-rf {
schematics: VCC3V4_RF
VCCIN_5V -> VCC3V4_RF
> + pinctrl-names = "default";
> + pinctrl-0 = <&vcc3v3_rf_pwren_en>;
schematics: RF_PWR_EN
> ...
> + vcc5v0_sysin: regulator-5v0-vcc-sysin {
schematics: VCC_SYSIN
> ...
> + vcc5v0_syson: regulator-5v0-vcc-syson {
schematics: VCC_SYSON
> ...
> + vcc5v0_usb30_otg0: regulator-5v0-vcc-usb-host {
> ...
> + vin-supply = <&vcc5v0_syson>;
VCCIN_5V -> VCC5V0_USB30_OTG0
> ...
> +&gmac1 {
> ...
> + tx_delay = <0x0>;
> + rx_delay = <0x0>;
Please remove the tx_delay and rx_delay, it's useless.
I know there is an error log, but please ignore it first.
> ...
> +&pinctrl {
> ...
> + bt_reg_on_h: bt-enable-h {
> + pcie_pwren_h: pcie-enable-h {
> + wifi_reg_on_h: wifi-enable-h {
> + vcc3v3_rf_pwren_en: vcc5v0-modem-en {
> + usb_host_pwren_h: vcc5v0-host-en {
obviously (
> + wifi_pwrseq: wifi-pwrseq {
> + compatible = "mmc-pwrseq-simple";
> ...
> +&pinctrl {
> ...
> + sdio-pwrseq {
I tend to write like this:
```
&pinctrl {
wifi {
wifi_reg_on_h: wifi-reg-on-h {
```
> + vcc_sd {
> + vcc_sd_h: vcc-sd-h {
Overwrite original to match `sdmmc0_pwren`
sdmmc0 {
sdmmc0_pwren: sdmmc0-pwren {
> + rockchip,pins = <0 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> + };
> +
Extra blank lines.
> +};
> ...
> &sdmmc1 {
> ...
> max-frequency = <150000000>;
`max-frequency = <150000000>;` already defined in rk356x.dtsi
> ...
> +&usb_host0_ohci {
> ...
> +&usb_host0_ehci {
&usb_host0_ehci {
&usb_host0_ohci {
Same for usb_host1
> ...
> &usb2phy1_host {
> phy-supply = <&vcc3v3_rf>;
> status = "okay";
> };
Is usb2phy1_host connected?
--
2.25.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-09-06 8:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 4:57 [PATCH v2 0/3] Add support for Ariaboard Photonicat RK3568 Junhao Xie
2024-09-06 4:57 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add prefix for Ariaboard Junhao Xie
2024-09-06 10:16 ` Krzysztof Kozlowski
2024-09-06 4:57 ` [PATCH v2 2/3] dt-bindings: arm: rockchip: Add Ariaboard Photonicat RK3568 Junhao Xie
2024-09-06 8:40 ` Chukun Pan
2024-09-06 9:45 ` Junhao Xie
2024-09-06 4:57 ` [PATCH v2 3/3] arm64: dts: rockchip: add dts for " Junhao Xie
2024-09-06 8:10 ` Chukun Pan [this message]
2024-09-06 14:12 ` Junhao Xie
2024-09-07 8:00 ` Chukun Pan
2024-09-06 19:37 ` [PATCH v2 0/3] Add support " Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240906081005.69334-1-amadeus@jmu.edu.cn \
--to=amadeus@jmu.edu.cn \
--cc=bigfoot@classfun.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox