Re: [PATCH v3 0/2] MIPI DSI phy for rk3588

Sebastian Reichel
2024-11-22T18:17:43Z

[-- Attachment #1.1: Type: text/plain, Size: 1848 bytes --]

Hi,

On Wed, Nov 13, 2024 at 11:10:16PM +0100, Heiko Stuebner wrote:
> This adds the phy driver need for DSI output on rk3588.
>
> The phy itself is used for both DSI output and CSI input, though the
> CSI part for the whole chain needs a lot more work, so is left out for
> now and only the DSI part implemented.
>
> This allows the rk3588 with its current VOP support to drive a DSI display
> using the DSI2 controller driver I'll submit in a next step.
>
> Only generic phy interfaces are used, so the DSI part is pretty straight
> forward.
>
> changes in v3:
> - add Krzysztof review tag to the binding
> - address Sebastian's review comments
> - better error handling
> - dropping empty function
> - headers
> - not using of_match_ptr - this should also make the
> test-robot happier
>
> changes in v2:
> - fix error in dt-binding example
> - drop unused frequency table
> - pull in some more recent improvements from the vendor-kernel
> which includes a lot less magic values
> - already include the support for rk3576
> - use dev_err_probe
>
> Heiko Stuebner (2):
> dt-bindings: phy: Add Rockchip MIPI CSI/DSI PHY schema
> phy: rockchip: Add Samsung CSI/DSI Combo DCPHY driver
>
> .../phy/rockchip,rk3588-mipi-dcphy.yaml | 82 +
> drivers/phy/rockchip/Kconfig | 12 +
> drivers/phy/rockchip/Makefile | 1 +
> .../phy/rockchip/phy-rockchip-samsung-dcphy.c | 1647 +++++++++++++++++
> 4 files changed, 1742 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/rockchip,rk3588-mipi-dcphy.yaml
> create mode 100644 drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c

The series works for me on the RK3588 EVB1:

Tested-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Greetings,

-- Sebastian

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]