Re: [PATCH v5 11/12] arm64: dts: rockchip: Fix proparties for pmic regulators for Radxa ROCK 5C

FUKAUMI Naoki
2024-12-17T00:53:50Z

On 12/16/24 22:41, Krzysztof Kozlowski wrote:
> On 16/12/2024 12:30, FUKAUMI Naoki wrote:
>> Fix proparties for dcdc-reg7 and nldo-reg3 regulators to match with
>
>
>
> You have so many typos in almost each commit msg. Here both in subject
> and commit msg.
>
> Run spell check before you send to the lists. Don't expect the reviewers
> to be your computer tools.

Sorry for my poor English. I'll check it next time.

> Explain what is being fixed here. Why would you prefer to match with
> vendor kernel?

Not my preference, but the only reference.

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

>> vendor kernel[1].
>>
>> [1] https://github.com/radxa/kernel/blob/linux-6.1-stan-rkr1/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
>>
>> Fixes: 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")
>> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
>> ---
>
>
>
>
> Best regards,
> Krzysztof