From: Jianfeng Liu <liujianfeng1994@gmail.com>
To: amadeus@jmu.edu.cn
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, heiko@sntech.de,
jonas@kwiboo.se, kishon@kernel.org, krzk+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-phy@lists.infradead.org,
linux-rockchip@lists.infradead.org, liujianfeng1994@gmail.com,
p.zabel@pengutronix.de, robh@kernel.org, vkoul@kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: rockchip: rk3568: add reset-names for combphy
Date: Sat, 4 Jan 2025 01:11:09 +0800 [thread overview]
Message-ID: <20250103171109.2726312-1-liujianfeng1994@gmail.com> (raw)
In-Reply-To: <20250103033016.79544-1-amadeus@jmu.edu.cn>
Hi,
On Fri, 3 Jan 2025 11:30:16 +0800, Chukun Pan wrote:
>Maybe the merge window is different. Can you test the following patch?
>
>```
>--- a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
>+++ b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
>@@ -325,6 +325,10 @@ static int rockchip_combphy_parse_dt(struct device *dev, struct rockchip_combphy
> priv->ext_refclk = device_property_present(dev, "rockchip,ext-refclk");
>
> priv->phy_rst = devm_reset_control_get(dev, "phy");
>+ /* fallback to old behaviour */
>+ if (IS_ERR_OR_NULL(priv->phy_rst))
>+ priv->phy_rst = devm_reset_control_array_get_exclusive(dev);
>+
> if (IS_ERR(priv->phy_rst))
> return dev_err_probe(dev, PTR_ERR(priv->phy_rst), "failed to get phy reset\n");
>
>```
Tested with rock-3a. This patch will fix dtb without reset-names property.
Best regards,
Jianfeng
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
prev parent reply other threads:[~2025-01-03 17:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 7:30 [PATCH 1/2] arm64: dts: rockchip: rk3568: add reset-names for combphy Chukun Pan
2024-11-22 7:30 ` [PATCH 2/2] phy: rockchip: naneng-combphy: fix phy reset Chukun Pan
2024-11-22 8:01 ` Heiko Stuebner
2024-11-23 22:28 ` FUKAUMI Naoki
2024-11-22 7:56 ` [PATCH 1/2] arm64: dts: rockchip: rk3568: add reset-names for combphy Heiko Stuebner
2024-11-22 8:12 ` Heiko Stuebner
2024-12-02 23:29 ` (subset) " Heiko Stuebner
2024-12-08 16:58 ` Vinod Koul
2025-01-02 15:16 ` Jianfeng Liu
2025-01-02 16:57 ` Jonas Karlman
2025-01-03 3:30 ` Chukun Pan
2025-01-03 10:26 ` Heiko Stübner
2025-01-03 17:11 ` Jianfeng Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250103171109.2726312-1-liujianfeng1994@gmail.com \
--to=liujianfeng1994@gmail.com \
--cc=amadeus@jmu.edu.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox