Re: [PATCH v1 3/3] arm64: dts: rockchip: Add Luckfox Omni3576 Carrier Board with Core3576 Module

Andrew Lunn
2025-05-02T21:54:20Z

> +&gmac1 {
> + clock_in_out = "output";
> + phy-handle = <&rgmii_phy1>;
> + phy-mode = "rgmii-rxid";

This is unlikely to be correct. It probably works, but that does not
make it correct.

> + pinctrl-names = "default";
> + pinctrl-0 = <&eth1m0_miim
> + &eth1m0_tx_bus2
> + &eth1m0_rx_bus2
> + &eth1m0_rgmii_clk
> + &eth1m0_rgmii_bus
> + &ethm0_clk1_25m_out>;
> + snps,reset-gpio = <&gpio2 RK_PB4 GPIO_ACTIVE_LOW>;
> + snps,reset-active-low;
> + snps,reset-delays-us = <0 20000 100000>;
> + tx_delay = <0x20>;
> + status = "disabled";
> +};

Please see the discussion about rgmii delays with other rockchip
boards from the last week, and

https://patchwork.kernel.org/project/netdevbpf/patch/20250430-v6-15-rc3-net-rgmii-delays-v2-1-099ae651d5e5@lunn.ch/

Andrew