Re: [PATCH v1 3/3] arm64: dts: rockchip: add DTs for Sakura Pi RK3308B

Heiko Stuebner
2025-05-13T19:05:15Z

Hi,

Am Dienstag, 13. Mai 2025, 18:35:14 Mitteleuropäische Sommerzeit schrieb Hsun Lai:

> + vcc5v0_sys: vcc5v0-sys {

preferred node-names for regulators is regulator-foo, so here please
regulator-vcc5v0-sys (phandle can stay as it is).

Same for all the other fixed-/pwm- regulators below.

> + compatible = "regulator-fixed";
> + regulator-name = "vcc5v0_sys";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + };
> +
> + vdd_core: vdd-core {
> + compatible = "pwm-regulator";
> + pwms = <&pwm0 0 5000 1>;
> + regulator-name = "vdd_core";
> + regulator-min-microvolt = <827000>;
> + regulator-max-microvolt = <1340000>;
> + regulator-init-microvolt = <1015000>;
> + regulator-settling-time-up-us = <250>;
> + regulator-always-on;
> + regulator-boot-on;
> + pwm-supply = <&vcc5v0_sys>;
> + };
> +
> + vdd_log: vdd-log {
> + compatible = "regulator-fixed";
> + regulator-name = "vdd_log";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <1050000>;
> + regulator-max-microvolt = <1050000>;
> + vin-supply = <&vcc5v0_sys>;
> + };
> +
> + vcc_ddr: vcc-ddr {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc_ddr";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <1500000>;
> + regulator-max-microvolt = <1500000>;
> + vin-supply = <&vcc5v0_sys>;
> + };
> +
> + vcc_1v8: vcc-1v8 {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc_1v8";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + vin-supply = <&vcc_io>;
> + };
> +
> + vcc_io: vcc-io {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc_io";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + vin-supply = <&vcc5v0_sys>;
> + };
> +
> + vcc_phy: vcc-phy-regulator {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc_phy";
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + vcc5v0_otg: vcc5v0-otg {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc5v0_otg";
> + regulator-always-on;
> + gpio = <&gpio0 RK_PC5 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + pinctrl-names = "default";
> + pinctrl-0 = <&otg_vbus_drv>;
> + vin-supply = <&vcc5v0_sys>;
> + };
> +
> +};

> +&i2c1 {

empty i2c controller? I guess it is routed to the external pins?
If so, could use a comment explaining that.

> +/* SPI0 for external gpio pin */
> +&spi0 {
> + status = "okay";
> +
> + spi_dev@0 {
> + compatible = "spidev";

having a generic spidev is not allowed. If there is an actual
device connected there, it should have a real compatible.
If that isn't a real device, this could be handled in an overlay.

> + reg = <0>;
> + spi-max-frequency = <0x2faf080>;
> + };
> +};
> +
> +/* SPI1 for ws2812*/
> +&spi1 {
> + status = "okay";
> +
> + spi_dev@0 {
> + compatible = "spidev";

same as above, please no generic spidev

> + reg = <0>;
> + spi-max-frequency = <0x2faf080>;
> + };
> +};
> +
> +&pinctrl {
> + pinctrl-names = "default";
> + pinctrl-0 = <&rtc_32k>;
> +
> + usb {

please sort these nodes alphabetically

> + otg_vbus_drv: otg-vbus-drv {
> + rockchip,pins = <0 RK_PC5 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> + };
> +
> + sdio-pwrseq {
> + wifi_enable_h: wifi-enable-h {
> + rockchip,pins = <0 RK_PA2 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> + };
> +
> + wifi {
> + wifi_host_wake: wifi-host-wake {
> + rockchip,pins = <0 RK_PA0 RK_FUNC_GPIO &pcfg_pull_down>;
> + };
> + };
> +
> + bluetooth {
> + bt_reg_on: bt-reg-on {
> + rockchip,pins = <4 RK_PB3 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> +
> + bt_wake_host: bt-wake-host {
> + rockchip,pins = <4 RK_PB4 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> +
> + host_wake_bt: host-wake-bt {
> + rockchip,pins = <4 RK_PB2 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> + };
> +};
> +
> +&pwm0 {
> + status = "okay";

status as last property

> + pinctrl-0 = <&pwm0_pin_pull_down>;
> +};
> +
> +&saradc {
> + vref-supply = <&vcc_1v8>;
> + status = "okay";
> +};
> +
> +&pwm3 {

please sort phandles alphabetically

> + status = "okay";
> +};
> +
> +&i2c1 {

same

> + status = "okay";
> +};

Thanks
Heiko