From: Jason Gunthorpe <jgg@ziepe.ca>
To: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Cc: joro@8bytes.org, will@kernel.org, robin.murphy@arm.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
heiko@sntech.de, nicolas.dufresne@collabora.com,
p.zabel@pengutronix.de, mchehab@kernel.org,
iommu@lists.linux.dev, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-media@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH 5/5] media: verisilicon: Flush IOMMU before decoding a frame
Date: Tue, 17 Jun 2025 12:58:22 -0300 [thread overview]
Message-ID: <20250617155822.GE1376515@ziepe.ca> (raw)
In-Reply-To: <20250616145607.116639-6-benjamin.gaignard@collabora.com>
On Mon, Jun 16, 2025 at 04:55:53PM +0200, Benjamin Gaignard wrote:
> Flush the IOMMU mapping before decoding a frame to ensure that all memory
> translations are properly applied.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> ---
> drivers/media/platform/verisilicon/hantro_drv.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
This is a really big red flag.
iommu translations are supposed to be controlled by the iommu driver
and should be flushed as part of the iommu map/unmap flows. It should
never be necessary to do something like this.
Jason
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-06-17 17:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 14:55 [PATCH 0/5] Add support for Verisilicon IOMMU used by media codec blocks Benjamin Gaignard
2025-06-16 14:55 ` [PATCH 1/5] dt-bindings: vendor-prefixes: Add Verisilicon Benjamin Gaignard
2025-06-16 15:15 ` Conor Dooley
2025-06-16 14:55 ` [PATCH 2/5] dt-bindings: iommu: verisilicon: Add binding for VSI IOMMU Benjamin Gaignard
2025-06-16 15:14 ` Conor Dooley
2025-06-16 15:30 ` Benjamin Gaignard
2025-06-16 15:42 ` Conor Dooley
2025-06-16 15:50 ` Benjamin Gaignard
2025-06-16 15:58 ` Conor Dooley
2025-06-16 16:06 ` Benjamin Gaignard
2025-06-16 21:19 ` Nicolas Dufresne
2025-06-16 14:55 ` [PATCH 3/5] iommu: Add verisilicon IOMMU driver Benjamin Gaignard
2025-06-17 13:04 ` Diederik de Haas
2025-06-17 13:48 ` Benjamin Gaignard
2025-06-17 16:32 ` Jason Gunthorpe
2025-06-18 12:04 ` Benjamin Gaignard
2025-06-18 13:27 ` Jason Gunthorpe
2025-06-18 4:53 ` kernel test robot
2025-06-16 14:55 ` [PATCH 4/5] arm64: dts: rockchip: Add verisilicon IOMMU node on RK3588 Benjamin Gaignard
2025-06-16 14:55 ` [PATCH 5/5] media: verisilicon: Flush IOMMU before decoding a frame Benjamin Gaignard
2025-06-17 15:58 ` Jason Gunthorpe [this message]
2025-06-17 16:01 ` Benjamin Gaignard
2025-06-17 16:04 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250617155822.GE1376515@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=benjamin.gaignard@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox