From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70E8DC7115D for ; Thu, 19 Jun 2025 17:03:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DbrkHj4gthaOP04dGknfpwkVPoRzHMqFqo7mLX/r7pU=; b=1v9g1x4AmAIrf9yuTqJ8Wxk6N/ 2tPWYlRIfP/Iw5XDah6TX4c5EHZBpClvuyAH8EoHGaFIoI7UsBFHuD30sJFXFr0uhQsvATGVzPJXB sANjrdm7r6hmqUQPm0mFD3aIb4tkTJ2IbjCHG1X38kcI8mBwAqQPBuqKtNSp/K/e6XEpwOiVfi00J nVYwhWqK3w1y+majMyFfYPe2G8zoXNJt/3Vsv/49qjOO6TTTED2ENAgRyyVNj8v50TT3E2kY06lYH y/Wq3Wa71CqcUwMfBVrs2BXtvf7bIGE9iKffIC8zwDtxUQ0XDPPSBqUDAGaGzqZrzC5R08QwDviID VhpP0DzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uSIfj-0000000Dgae-2CuZ; Thu, 19 Jun 2025 17:03:31 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uSGmo-0000000DLkS-2H9b; Thu, 19 Jun 2025 15:02:43 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 03030453C6; Thu, 19 Jun 2025 15:02:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD4C4C4CEEA; Thu, 19 Jun 2025 15:02:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750345361; bh=WMUgOCPru52VAFqEHtr6GwXaBkUBQdB2s1jxRDDNld0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YX0TziWK1LG1a7QkFBlLUDt9JBwOReEQ9+u42HbJfQwQFeLvUjfTgbpIedIwqhvT2 IJqmHF6ev3cY1lPLf/l0TJebZiPvvp1YXfAmB7kWYNXtFJaQKyV0gz+GnlgYVWpq9W 1tHjLm3EDkj/QmvXjX7lfsTq5zfABrg4eUjbIuJCFZl4iKsHdpYYLvbIAFCbteRaBr vXTKnEIXRniwycPDhoHypmCNdghR35KGofNaOBYiid1nnuLRkiNYKUbS8nmhZWuW8d uMb0oiQtuQDlpZuPqQLZn53O0B4/cdDz4G2//V8GYYoTchb7xsswUbhLbEkmiBFqtX vl+UdsYqQVbhQ== Date: Thu, 19 Jun 2025 16:02:36 +0100 From: Conor Dooley To: Sebastian Reichel Cc: Benjamin Gaignard , joro@8bytes.org, will@kernel.org, robin.murphy@arm.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, heiko@sntech.de, nicolas.dufresne@collabora.com, jgg@ziepe.ca, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH v3 2/5] dt-bindings: iommu: verisilicon: Add binding for VSI IOMMU Message-ID: <20250619-nape-iphone-0fd4f9889452@spud> References: <20250619131232.69208-1-benjamin.gaignard@collabora.com> <20250619131232.69208-3-benjamin.gaignard@collabora.com> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250619_080242_598775_2965507C X-CRM114-Status: GOOD ( 15.31 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3842957301505470242==" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org --===============3842957301505470242== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZsCqWODAaq6bj8Vt" Content-Disposition: inline --ZsCqWODAaq6bj8Vt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 19, 2025 at 04:19:32PM +0200, Sebastian Reichel wrote: > Hi, >=20 > On Thu, Jun 19, 2025 at 03:12:23PM +0200, Benjamin Gaignard wrote: > > +properties: > > + compatible: > > + items: > > + - const: verisilicon,iommu > > + - const: rockchip,rk3588-iommu-1.2 >=20 > The entries should be ordered the other way around, so that the > "generic" compatible is the fallback. Also the 1.2 version is from > Verisilicon. It does not really make sense for Rockchip. So I > think it should look like this: >=20 > properties: > compatible: > items: > - const: rockchip,rk3588-av1-iommu > - const: verisilicon,iommu-1.2 If you're not sure Benjamin, please just ask questions. There's been like 3 versions of this patch, soon to be 4, in like 3 days, two of which could have been avoided if you just asked "is this what you mean"? --ZsCqWODAaq6bj8Vt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaFQmjAAKCRB4tDGHoIJi 0mu2AQDy10QjeZsSnzVsEXfW6RViKo+rWauSa17R3QQdXnwOggEArRSd9DXggCSu +9Yh5AMC+TMbCL1HN15ms1SSzBkkVgY= =sX7T -----END PGP SIGNATURE----- --ZsCqWODAaq6bj8Vt-- --===============3842957301505470242== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip --===============3842957301505470242==--