Re: [PATCH v3 2/5] dt-bindings: iommu: verisilicon: Add binding for VSI IOMMU

Sebastian Reichel
2025-06-19T17:03:02Z

[-- Attachment #1.1: Type: text/plain, Size: 1747 bytes --]

Hi,

On Thu, Jun 19, 2025 at 03:12:23PM +0200, Benjamin Gaignard wrote:
> +properties:
> + compatible:
> + items:
> + - const: verisilicon,iommu
> + - const: rockchip,rk3588-iommu-1.2

The entries should be ordered the other way around, so that the
"generic" compatible is the fallback. Also the 1.2 version is from
Verisilicon. It does not really make sense for Rockchip. So I
think it should look like this:

properties:
compatible:
items:
- const: rockchip,rk3588-av1-iommu
- const: verisilicon,iommu-1.2

Otherwise LGTM.

-- Sebastian

> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: Core clock
> + - description: Interface clock
> +
> + clock-names:
> + items:
> + - const: core
> + - const: iface
> +
> + "#iommu-cells":
> + const: 0
> +
> + power-domains:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - "#iommu-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/rockchip,rk3588-cru.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + bus {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + iommu@fdca0000 {
> + compatible = "verisilicon,iommu","rockchip,rk3588-iommu-1.2";
> + reg = <0x0 0xfdca0000 0x0 0x600>;
> + interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH 0>;
> + clocks = <&cru ACLK_AV1>, <&cru PCLK_AV1>;
> + clock-names = "core", "iface";
> + #iommu-cells = <0>;
> + };
> + };
> --
> 2.43.0
>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]