* [PATCH 1/3] dt-bindings: display: ingenic,jz4780-hdmi: Add missing clock-names
2025-08-20 7:02 [PATCH 0/3] dt-bindings: display: Few cleanups Krzysztof Kozlowski
@ 2025-08-20 7:02 ` Krzysztof Kozlowski
2025-08-20 7:02 ` [PATCH 2/3] dt-bindings: display: ti,tdp158: Add missing reg constraint Krzysztof Kozlowski
2025-08-20 7:02 ` [PATCH 3/3] dt-bindings: display: rockchip,dw-mipi-ds: Narrow clocks for rockchip,rk3288-mipi-dsi Krzysztof Kozlowski
2 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-20 7:02 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Simona Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, H. Nikolaus Schaller,
Arnaud Vrac, Pierre-Hugues Husson, Sandy Huang,
Heiko Stübner, Andy Yan
Cc: dri-devel, devicetree, linux-kernel, linux-arm-kernel,
linux-rockchip, Krzysztof Kozlowski
The binding references synopsys,dw-hdmi.yaml schema which defines both
'clocks' and 'clock-names' with variable length, therefore we need here
also same constraint for 'clock-names' as for 'clocks'.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml
index 0b27df429bdce0b7e080ab291ee0c4c6b51f8e1f..84df3cf239d5bedf8a5806bb48507fea207c7167 100644
--- a/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml
@@ -26,6 +26,9 @@ properties:
clocks:
maxItems: 2
+ clock-names:
+ maxItems: 2
+
ports:
$ref: /schemas/graph.yaml#/properties/ports
--
2.48.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/3] dt-bindings: display: ti,tdp158: Add missing reg constraint
2025-08-20 7:02 [PATCH 0/3] dt-bindings: display: Few cleanups Krzysztof Kozlowski
2025-08-20 7:02 ` [PATCH 1/3] dt-bindings: display: ingenic,jz4780-hdmi: Add missing clock-names Krzysztof Kozlowski
@ 2025-08-20 7:02 ` Krzysztof Kozlowski
2025-08-20 7:02 ` [PATCH 3/3] dt-bindings: display: rockchip,dw-mipi-ds: Narrow clocks for rockchip,rk3288-mipi-dsi Krzysztof Kozlowski
2 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-20 7:02 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Simona Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, H. Nikolaus Schaller,
Arnaud Vrac, Pierre-Hugues Husson, Sandy Huang,
Heiko Stübner, Andy Yan
Cc: dri-devel, devicetree, linux-kernel, linux-arm-kernel,
linux-rockchip, Krzysztof Kozlowski
Device can be used over I2C bus, so it documents 'reg' property, however
it misses to constrain it to actual I2C address.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/display/bridge/ti,tdp158.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/bridge/ti,tdp158.yaml b/Documentation/devicetree/bindings/display/bridge/ti,tdp158.yaml
index 1c522f72c4bae3313930b5c76dd04dde1aef5151..721da44054e19ff04fe9d8c1dc31a9168e8f79f5 100644
--- a/Documentation/devicetree/bindings/display/bridge/ti,tdp158.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/ti,tdp158.yaml
@@ -17,6 +17,7 @@ properties:
# The reg property is required if and only if the device is connected
# to an I2C bus. In pin strap mode, reg must not be specified.
reg:
+ maxItems: 1
description: I2C address of the device
# Pin 36 = Operation Enable / Reset Pin
--
2.48.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 3/3] dt-bindings: display: rockchip,dw-mipi-ds: Narrow clocks for rockchip,rk3288-mipi-dsi
2025-08-20 7:02 [PATCH 0/3] dt-bindings: display: Few cleanups Krzysztof Kozlowski
2025-08-20 7:02 ` [PATCH 1/3] dt-bindings: display: ingenic,jz4780-hdmi: Add missing clock-names Krzysztof Kozlowski
2025-08-20 7:02 ` [PATCH 2/3] dt-bindings: display: ti,tdp158: Add missing reg constraint Krzysztof Kozlowski
@ 2025-08-20 7:02 ` Krzysztof Kozlowski
2025-08-20 8:21 ` Heiko Stübner
2 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-20 7:02 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Simona Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, H. Nikolaus Schaller,
Arnaud Vrac, Pierre-Hugues Husson, Sandy Huang,
Heiko Stübner, Andy Yan
Cc: dri-devel, devicetree, linux-kernel, linux-arm-kernel,
linux-rockchip, Krzysztof Kozlowski
The binding allows in top-level from one to four clocks and each variant
narrows the choice, but rockchip,rk3288-mipi-dsi missed the minItems.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/display/rockchip/rockchip,dw-mipi-dsi.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-mipi-dsi.yaml
index 0881e82deb1105e4f92843380c0183569f688f08..c59df3c1a3f78ae0d345dc725f4dfb3eedb3de22 100644
--- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-mipi-dsi.yaml
+++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-mipi-dsi.yaml
@@ -97,9 +97,11 @@ allOf:
then:
properties:
clocks:
+ minItems: 2
maxItems: 2
clock-names:
+ minItems: 2
maxItems: 2
- if:
--
2.48.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] dt-bindings: display: rockchip,dw-mipi-ds: Narrow clocks for rockchip,rk3288-mipi-dsi
2025-08-20 7:02 ` [PATCH 3/3] dt-bindings: display: rockchip,dw-mipi-ds: Narrow clocks for rockchip,rk3288-mipi-dsi Krzysztof Kozlowski
@ 2025-08-20 8:21 ` Heiko Stübner
0 siblings, 0 replies; 5+ messages in thread
From: Heiko Stübner @ 2025-08-20 8:21 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Simona Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, H. Nikolaus Schaller,
Arnaud Vrac, Pierre-Hugues Husson, Sandy Huang, Andy Yan,
Krzysztof Kozlowski
Cc: dri-devel, devicetree, linux-kernel, linux-arm-kernel,
linux-rockchip, Krzysztof Kozlowski
Hi,
Am Mittwoch, 20. August 2025, 09:02:42 Mitteleuropäische Sommerzeit schrieb Krzysztof Kozlowski:
> The binding allows in top-level from one to four clocks and each variant
> narrows the choice, but rockchip,rk3288-mipi-dsi missed the minItems.
subject is missing an "i" in rockchip,dw-mipi-ds(i)
Other than that
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/display/rockchip/rockchip,dw-mipi-dsi.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-mipi-dsi.yaml
> index 0881e82deb1105e4f92843380c0183569f688f08..c59df3c1a3f78ae0d345dc725f4dfb3eedb3de22 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-mipi-dsi.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-mipi-dsi.yaml
> @@ -97,9 +97,11 @@ allOf:
> then:
> properties:
> clocks:
> + minItems: 2
> maxItems: 2
>
> clock-names:
> + minItems: 2
> maxItems: 2
>
> - if:
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 5+ messages in thread