From: Jonathan Cameron <jic23@kernel.org>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: "Xichao Zhao" <zhao.xichao@vivo.com>,
"Andreas Klinger" <ak@it-klinger.de>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Haibo Chen" <haibo.chen@nxp.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Marius Cristea" <marius.cristea@microchip.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Kevin Hilman" <khilman@baylibre.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Francesco Dolcini" <francesco@dolcini.it>,
"João Paulo Gonçalves" <jpaulo.silvagoncalves@gmail.com>,
"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
"open list:AVIA HX711 ANALOG DIGITAL CONVERTER IIO DRIVER"
<linux-iio@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:NXP i.MX 7D/6SX/6UL/93 AND VF610 ADC DRIVER"
<imx@lists.linux.dev>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson SoC support"
<linux-amlogic@lists.infradead.org>,
"open list:ARM/Rockchip SoC support"
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH 2/7] iio: adc: Remove dev_err_probe() if error is -ENOMEM
Date: Mon, 25 Aug 2025 09:36:22 +0100 [thread overview]
Message-ID: <20250825093622.68c8e5cc@jic23-huawei> (raw)
In-Reply-To: <CAFBinCDDMo2Dm1UAoB4QKyf-KKoRUTNNg4i7Qh_vgZh71trMNg@mail.gmail.com>
On Thu, 21 Aug 2025 22:31:51 +0200
Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> On Thu, Aug 21, 2025 at 10:07 AM Xichao Zhao <zhao.xichao@vivo.com> wrote:
> >
> > The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
> > Therefore, remove the useless call to dev_err_probe(), and just
> > return the value instead.
> >
> > Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
> > ---
> > drivers/iio/adc/hx711.c | 2 +-
> > drivers/iio/adc/imx93_adc.c | 3 +--
> > drivers/iio/adc/mcp3564.c | 2 +-
> > drivers/iio/adc/meson_saradc.c | 2 +-
> For meson_saradc:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
Hi Martin (applies to others in this series),
For a comment about a tag please use the style submitting-patches suggests.
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> # for meson_saradc
Then the tooling picks it automatically. Sometimes I remember to edit commits
to tidy this up, but not always!
Jonathan
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-08-25 8:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 8:06 [PATCH 0/7] iio: Remove dev_err_probe() if error is -ENOMEM Xichao Zhao
2025-08-21 8:06 ` [PATCH 2/7] iio: adc: " Xichao Zhao
2025-08-21 20:31 ` Martin Blumenstingl
2025-08-25 8:36 ` Jonathan Cameron [this message]
2025-08-21 8:13 ` [PATCH 0/7] iio: " Andy Shevchenko
2025-08-21 11:50 ` Crt Mori
2025-08-21 12:47 ` Andy Shevchenko
2025-08-25 8:41 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250825093622.68c8e5cc@jic23-huawei \
--to=jic23@kernel.org \
--cc=ak@it-klinger.de \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=festevam@gmail.com \
--cc=francesco@dolcini.it \
--cc=haibo.chen@nxp.com \
--cc=heiko@sntech.de \
--cc=hvilleneuve@dimonoff.com \
--cc=imx@lists.linux.dev \
--cc=jbrunet@baylibre.com \
--cc=jpaulo.silvagoncalves@gmail.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=marius.cristea@microchip.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=nuno.sa@analog.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=zhao.xichao@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox