From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kaison Deng <dkx@t-chip.com.cn>
Cc: Rob Herring <robh@kernel.org>, Jimmy Hon <honyuenkwun@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>, Wayne Chou <zxf@t-chip.com.cn>,
Quentin Schulz <quentin.schulz@cherry.de>,
Dragan Simic <dsimic@manjaro.org>,
Jonas Karlman <jonas@kwiboo.se>, FUKAUMI Naoki <naoki@radxa.com>,
Peter Robinson <pbrobinson@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Firefly ROC-RK3588-RT
Date: Tue, 9 Sep 2025 09:22:47 +0200 [thread overview]
Message-ID: <20250909-romantic-efficient-sambar-4fc38f@kuoka> (raw)
In-Reply-To: <27b2ce7950fdbf28c6c8404c3f8be3c1c35d6b3c.1757322046.git.dkx@t-chip.com.cn>
On Tue, Sep 09, 2025 at 09:31:47AM +0800, Kaison Deng wrote:
> This documents Firefly ROC-RK3588-RT which is a SBC based on RK3588 SoC.
>
> Link: https://en.t-firefly.com/product/industry/rocrk3588rt
>
> Signed-off-by: Kaison Deng <dkx@t-chip.com.cn>
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index f9ee77f17ad7..6aceaa8acbb2 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -258,6 +258,11 @@ properties:
> - const: firefly,roc-rk3576-pc
> - const: rockchip,rk3576
>
> + - description: Firefly ROC-RK3588-RT
> + items:
> + - const: firefly,roc-rk3588-rt
That's just enum with ROC-RK3576-PC. BTW, all these descriptionis are
completely redundant. Actually getting harmful, because copy+paste of
the same is only obfuscating code.
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-09-09 8:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 1:31 [PATCH v2 0/2] Add support for Firefly ROC-RK3588-RT Kaison Deng
2025-09-09 1:31 ` [PATCH v2 1/2] dt-bindings: arm: rockchip: Add " Kaison Deng
2025-09-09 7:22 ` Krzysztof Kozlowski [this message]
2025-09-10 5:47 ` Kaison Deng
2025-09-10 7:10 ` Krzysztof Kozlowski
2025-09-09 1:31 ` [PATCH v2 2/2] arm64: dts: rockchip: Add devicetree for the ROC-RK3588-RT Kaison Deng
2025-09-09 12:31 ` Andrew Lunn
2025-09-10 2:55 ` Kaison
2025-09-10 12:15 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250909-romantic-efficient-sambar-4fc38f@kuoka \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dkx@t-chip.com.cn \
--cc=dsimic@manjaro.org \
--cc=heiko@sntech.de \
--cc=honyuenkwun@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=naoki@radxa.com \
--cc=pbrobinson@gmail.com \
--cc=quentin.schulz@cherry.de \
--cc=robh@kernel.org \
--cc=zxf@t-chip.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox