From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAC38CAC582 for ; Fri, 12 Sep 2025 09:04:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O3qOAii7zKaqSJ0J9CsVoUt3a/zcMMCUn1dJu/LbA4s=; b=eBlXrcrlZHrbE3 Bw80889i5bC1gegxaTtarj2dh+g+fFPhnYuOjoXpkN1ZiOU3s4+bK6SU7pJhf6++7RRjHJgjVQOkB rqSP7pT4QgDkBUpFOkm4kAuyyE0llGlsovOJbiB/qm8bG6WhUFqsSWqdC4/4rmGS9V/eYHv6mcfhe MlEGFT5yqHQJIzvhhMa4BgABb2CJ2PA7Imob8QvaepfkK/nsO/iKEmuUf7k0Q9LuzvlftVzrP1mPu 8XuS1fxpQUB1Yoiv30bGSvYPAf+6qKnL+WSf43SHQJvMGcrurYY8+qHAZkrIomUduRUMTV3Of/N5k GKjMRUQ+EfphiLALxrnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uwzi1-0000000888S-2nju; Fri, 12 Sep 2025 09:04:45 +0000 Received: from mail-m3281.qiye.163.com ([220.197.32.81]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uwzhz-0000000883k-0VgO; Fri, 12 Sep 2025 09:04:44 +0000 Received: from zyb-HP-ProDesk-680-G2-MT.. (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 2298a0eda; Fri, 12 Sep 2025 16:59:35 +0800 (GMT+08:00) From: Damon Ding To: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, jingoohan1@gmail.com, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, alim.akhtar@samsung.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, dmitry.baryshkov@oss.qualcomm.com, dianders@chromium.org, m.szyprowski@samsung.com, luca.ceresoli@bootlin.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Damon Ding Subject: [PATCH v5 15/17] drm/bridge: analogix_dp: Remove panel disabling and enabling in analogix_dp_set_bridge() Date: Fri, 12 Sep 2025 16:58:44 +0800 Message-Id: <20250912085846.7349-16-damon.ding@rock-chips.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250912085846.7349-1-damon.ding@rock-chips.com> References: <20250912085846.7349-1-damon.ding@rock-chips.com> MIME-Version: 1.0 X-HM-Tid: 0a993d26c6b703a3kunm813a8c8ea462ec X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGh9NS1ZCQxhLTUpKSB0YTUlWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSEpKQk 1VSktLVUpCWQY+ DKIM-Signature: a=rsa-sha256; b=PgTksgpc/PwYaGUTj6Klp8yoOt6TxyzDZ8x4VQuQkvqqM7fmdM4IiV4LrrmsFPvCYX46rjoAWCJRWvO5m/DpYFs5/mdd/xKukI3uefNgCy+qb8mrjvzdh4yx4qg52m599JtqQRFvtx+evaho3SXqU7yJUn+r7JDD+V4HY0aSqwE=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=SWJejH2sMKm/oiMWo0ZDbrxLAvaEfmo2OLTed8h96hg=; h=date:mime-version:subject:message-id:from; X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250912_020443_359247_6AA196AB X-CRM114-Status: GOOD ( 11.11 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org The &drm_panel_funcs.enable() and &drm_panel_funcs.disable() mainly help turn on/off the backlight to make the image visible, and the backlight operations are even needless if drm_panel_of_backlight() or drm_panel_dp_aux_backlight() is applied, in which case the enabling and disabling process just add necessary delays. Therefore, it should make sense to remove panel disabling and move panel enabling after analogix_dp_set_bridge() finished. Signed-off-by: Damon Ding --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 66d0cca1f268..c98058e9c917 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -749,9 +749,6 @@ static int analogix_dp_commit(struct analogix_dp_device *dp) { int ret; - /* Keep the panel disabled while we configure video */ - drm_panel_disable(dp->plat_data->panel); - ret = analogix_dp_train_link(dp); if (ret) { dev_err(dp->dev, "unable to do link train, ret=%d\n", ret); @@ -771,9 +768,6 @@ static int analogix_dp_commit(struct analogix_dp_device *dp) return ret; } - /* Safe to enable the panel now */ - drm_panel_enable(dp->plat_data->panel); - /* Check whether panel supports fast training */ ret = analogix_dp_fast_link_train_detection(dp); if (ret) @@ -1156,6 +1150,7 @@ static void analogix_dp_bridge_atomic_enable(struct drm_bridge *bridge, while (timeout_loop < MAX_PLL_LOCK_LOOP) { if (analogix_dp_set_bridge(dp) == 0) { dp->dpms_mode = DRM_MODE_DPMS_ON; + drm_panel_enable(dp->plat_data->panel); return; } dev_err(dp->dev, "failed to set bridge, retry: %d\n", -- 2.34.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip