From: Jason Gunthorpe <jgg@ziepe.ca>
To: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Cc: "Jörg Rödel" <joro@8bytes.org>,
"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
robin.murphy@arm.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, heiko@sntech.de, p.zabel@pengutronix.de,
mchehab@kernel.org, iommu@lists.linux.dev,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, kernel@collabora.com,
linux-media@vger.kernel.org
Subject: Re: [PATCH v9 3/7] iommu: Add verisilicon IOMMU driver
Date: Fri, 12 Sep 2025 15:32:06 -0300 [thread overview]
Message-ID: <20250912183206.GH882933@ziepe.ca> (raw)
In-Reply-To: <694b9ba15cd67f41a38f4a65a3811f035cf8e99d.camel@collabora.com>
On Fri, Sep 12, 2025 at 01:37:11PM -0400, Nicolas Dufresne wrote:
> To me this rejection isn't about Benjamin's driver, all iommu seems to look
> alike, so anyone else that would have sent new driver would have face the same
> issue.
Yes, many drivers looks approximately alike.. To the extent possible
we should be making more helpers and tools to lift common patterns out
of the drivers. I don't know how much of that applies to rockchip vs
verisilicon though. Obviously I'm tackling the page table stuff.
Much of the other common code is tracking attachments and invalidation
requirements. I'm hopeful the general method Nicolin is working on can
be lifted and shared. Certainly it is better than what is in any of
the three server focused drivers. But I don't know how much this
brings to these simpler drivers.
It seems strange to be talking about merging drivers that don't share
a common IP supplier or register programming model.
Jason
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-09-12 18:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 15:57 [PATCH v9 0/7] Add support for Verisilicon IOMMU used by media codec blocks Benjamin Gaignard
2025-09-11 15:57 ` [PATCH v9 1/7] dt-bindings: vendor-prefixes: Add Verisilicon Benjamin Gaignard
2025-09-11 15:57 ` [PATCH v9 2/7] dt-bindings: iommu: verisilicon: Add binding for VSI IOMMU Benjamin Gaignard
2025-09-11 15:57 ` [PATCH v9 3/7] iommu: Add verisilicon IOMMU driver Benjamin Gaignard
2025-09-12 11:47 ` Jörg Rödel
2025-09-12 12:33 ` Benjamin Gaignard
2025-09-12 17:37 ` Nicolas Dufresne
2025-09-12 18:32 ` Jason Gunthorpe [this message]
2025-09-13 5:58 ` Jörg Rödel
2025-09-15 22:58 ` Jason Gunthorpe
2025-09-16 8:48 ` Will Deacon
2025-09-16 9:30 ` Benjamin Gaignard
2025-09-16 13:02 ` Jason Gunthorpe
2025-12-12 3:31 ` Jianfeng Liu
2025-12-12 8:51 ` Benjamin Gaignard
2025-09-11 15:57 ` [PATCH v9 4/7] MAINTAINERS: Add entry for Verisilicon " Benjamin Gaignard
2025-09-11 15:57 ` [PATCH v9 5/7] media: verisilicon: AV1: Restore IOMMU context before decoding a frame Benjamin Gaignard
2025-09-11 15:57 ` [PATCH v9 6/7] arm64: dts: rockchip: Add verisilicon IOMMU node on RK3588 Benjamin Gaignard
2025-09-11 15:57 ` [PATCH v9 7/7] arm64: defconfig: enable Verisilicon IOMMU for Rockchip RK3588 Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250912183206.GH882933@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=benjamin.gaignard@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox