From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E01D4CCD190 for ; Mon, 13 Oct 2025 14:15:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=logW/R4BNkXdm0gzhGTIAXc8hm8OJdnR+rjzZyEeN/s=; b=3P9QBKtg9eKQzH TfgDocR+ILMtQJ70+qyzsgYP4YooHqDrF+xAE/WfZH2iXUiU7xxLk/AsTNC4kFea9ni8EtjtzHMPU tgB/XD308NvS0zErVVh1iUNXatgEk/Ty6m7TbTnjYVpgESPKQG9FaHtd1o5yHYvZAE79NYZXjCMp1 qZoQAy+vuPbFTTB9JK8u+7W4IRgqw3rqrxfBV2UghocXpP3edTofqtYtVdRfSbK8f/lvhClxkG73y zZhWibEkqyNOGwZoTpgqMSdzXkhZV9f6O/V4HVVy13q3NQlvWxR5a+fsmqqJmQneJbB7V8SisAKn1 qQfYnnSx/Way49FAyA6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v8JL0-0000000DM5h-2qYm; Mon, 13 Oct 2025 14:15:46 +0000 Received: from mail-lf1-f50.google.com ([209.85.167.50]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v8JKR-0000000DKz5-0FBK for linux-rockchip@lists.infradead.org; Mon, 13 Oct 2025 14:15:12 +0000 Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-57a292a3a4bso5390569e87.3 for ; Mon, 13 Oct 2025 07:15:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1760364908; x=1760969708; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LGG/+lvAfLoFYTFsHBbdKee0g975J4ynYIjn3miRvz8=; b=hnHlv6Ca2lVjBc28KpZT2/7MBeMfBu7FGl0/r4xee1bqgV7lsCtpKWDwCQRnFxKlCx Yf/1S1pof1WGbwnBWlpIPV+XkFM4cqiJgwli2lj1PGmWXFjPBEWyFY5qjJ135dtj6h9B a3NABlLu8AnbfJeAs5SsYa/uUnAv9SrV4nyQY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760364908; x=1760969708; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LGG/+lvAfLoFYTFsHBbdKee0g975J4ynYIjn3miRvz8=; b=C9jQTEK7FfRLrV83SgtMjhCzWJu/1G5H1b9sAPVK1/zU4udJqsVII8NM9J8GD0gGg6 mFO9Jg1YxhoZ2EDW0NDB37gcqhe1VHn4DQxv+IxObibV3n2WpusZAEg/KKyWMBr6q2o3 j78KvMo3eIXg9WV9CQSEeWv7yHF27I2JrQJWlK7ziKiCoUbbkPA7WBx6rVtcEd6W1Yj3 O1b8H3F2XbY/m0K8O86ebs/l+iZHQQmd65bCWWrt2lAyAtbGhaFkFOUVPC5WPxUnzCat BiCNC/AkWOngdiQZDGp0f/6x3cALNqY42WDPR3S6RUXmPnZKIP7wCo1NzGR9LA6w1EPY yM9Q== X-Forwarded-Encrypted: i=1; AJvYcCW86XuzYMbJBGQSe6ELQCwlBT/jvS6nHp0q7zyal0e5CuQqMw1zYAKLMJKk7a4UZ+F6NmU9lYyVgY/3yjKoxA==@lists.infradead.org X-Gm-Message-State: AOJu0Ywpvay+6Ex7mhcn2gdahF5HQcMBgPKZqu5/n5XcOEKyQqNOTe9D +rVv8Pp1YdMumJN/u4OA0o4EwqFhhPcUK9S7Y1pKILzUnm8DxNTfe+U328R9h84oyw== X-Gm-Gg: ASbGnctNqG1918QiqxIsegv9A7FDbV3W9jEiWvap3xCHJwK92UfYhVVKoj8ehP3hprK 20A81OojrIDzqZui4N9GB6XrTGbz17mfmYLORoeQd4mHkyPk/dOxDAaCl5uSvWJEJoPr2qyo7Gx L1fXdvXOoYK/y4TLyjnyIJml7sMFFJ6FrhMHGoymCwhaCfDy7rPmaG2wGQlCEcHzabrIZW8Jybs Y+24obZnw/Wrq2kxdVlkjakaMZEVNn2r4PZqmC/JCvGpZmkg+TWiqGh4SrBNUD/uDQ5V2NsJi0L MgiUviPHNx0EpmKBmUeOX5EDUnagj84H30Oo0r11MgLq5Knr3W8ZTX6ff3OGBhzpVLvxR6757fD HdY3GwXGRSDNrQSdScWGxyDvNz+IbWy7iOD8xdpa153OFCxqReuhh2iwOwoLUhAfJqrw/I4t1yu 4A7gvSBwErA4gd8zw/0pl4ExGcJspm/9mT1+RsKdc= X-Google-Smtp-Source: AGHT+IHonGCa8by4IRlUhFwqne0G+xChLaB77A4Elu7KHX/ytkwCKxhNDSfo6zsqaOoV+Q8fGGx9SA== X-Received: by 2002:a05:6512:1093:b0:587:a4fa:1e50 with SMTP id 2adb3069b0e04-5906dae5b56mr5886844e87.41.1760364908274; Mon, 13 Oct 2025 07:15:08 -0700 (PDT) Received: from ribalda.c.googlers.com (56.213.88.34.bc.googleusercontent.com. [34.88.213.56]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-590881e4e58sm4165256e87.25.2025.10.13.07.15.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Oct 2025 07:15:07 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 13 Oct 2025 14:15:12 +0000 Subject: [PATCH 32/32] media: staging/ipu7: Use %pe format specifier MIME-Version: 1.0 Message-Id: <20251013-ptr_err-v1-32-2c5efbd82952@chromium.org> References: <20251013-ptr_err-v1-0-2c5efbd82952@chromium.org> In-Reply-To: <20251013-ptr_err-v1-0-2c5efbd82952@chromium.org> To: Linus Walleij , Dmitry Torokhov , Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , =?utf-8?q?Krzysztof_Ha=C5=82asa?= , Tomi Valkeinen , Leon Luo , Kieran Bingham , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Niklas_S=C3=B6derlund?= , Julien Massot , Jacopo Mondi , Daniel Scally , Dave Stevenson , Benjamin Mugnier , Sylvain Petinot , Yong Zhi , Bingbu Cao , Tianshu Qiu , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Matthias Brugger , AngeloGioacchino Del Regno , Rui Miguel Silva , Laurent Pinchart , Martin Kepplinger , Purism Kernel Team , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Dafna Hirschfeld , Heiko Stuebner , Sylwester Nawrocki , Krzysztof Kozlowski , Alim Akhtar , Yemike Abhilash Chandra , Greg Kroah-Hartman Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-staging@lists.linux.dev, Ricardo Ribalda X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251013_071511_178630_3B8B2BFE X-CRM114-Status: GOOD ( 12.30 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org The %pe format specifier is designed to print error pointers. It prints a symbolic error name (eg. -EINVAL) and it makes the code simpler by omitting PTR_ERR(). This patch fixes this cocci report: ./ipu7/ipu7-isys-csi-phy.c:311:23-30: WARNING: Consider using %pe to print PTR_ERR() ./ipu7/ipu7-isys-csi2.c:59:22-29: WARNING: Consider using %pe to print PTR_ERR() Signed-off-by: Ricardo Ribalda --- drivers/staging/media/ipu7/ipu7-isys-csi-phy.c | 4 ++-- drivers/staging/media/ipu7/ipu7-isys-csi2.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/ipu7/ipu7-isys-csi-phy.c b/drivers/staging/media/ipu7/ipu7-isys-csi-phy.c index b8c5db7ae3009e16264d7aaca6d4d237c1402ab7..2d57178835188a44b002b38712437cbd551751a5 100644 --- a/drivers/staging/media/ipu7/ipu7-isys-csi-phy.c +++ b/drivers/staging/media/ipu7/ipu7-isys-csi-phy.c @@ -307,8 +307,8 @@ static int ipu7_isys_csi_ctrl_dids_config(struct ipu7_isys_csi2 *csi2, u32 id) pad = media_entity_remote_source_pad_unique(&csi2->asd.sd.entity); if (IS_ERR(pad)) { - dev_warn(dev, "can't get remote source pad of %s (%ld)\n", - csi2->asd.sd.name, PTR_ERR(pad)); + dev_warn(dev, "can't get remote source pad of %s (%pe)\n", + csi2->asd.sd.name, pad); return PTR_ERR(pad); } diff --git a/drivers/staging/media/ipu7/ipu7-isys-csi2.c b/drivers/staging/media/ipu7/ipu7-isys-csi2.c index 4023db4a6466dd57f0ac007847bdd74bcdf394f7..f34eabfe8a985f29fa48b4a8896a058fde2f2b2f 100644 --- a/drivers/staging/media/ipu7/ipu7-isys-csi2.c +++ b/drivers/staging/media/ipu7/ipu7-isys-csi2.c @@ -55,8 +55,8 @@ s64 ipu7_isys_csi2_get_link_freq(struct ipu7_isys_csi2 *csi2) src_pad = media_entity_remote_source_pad_unique(&csi2->asd.sd.entity); if (IS_ERR(src_pad)) { dev_err(&csi2->isys->adev->auxdev.dev, - "can't get source pad of %s (%ld)\n", - csi2->asd.sd.name, PTR_ERR(src_pad)); + "can't get source pad of %s (%pe)\n", + csi2->asd.sd.name, src_pad); return PTR_ERR(src_pad); } -- 2.51.0.760.g7b8bcc2412-goog _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip