Re: [PATCH v3] PCI: dw-rockchip: Prevent advertising L1 Substates support

Manivannan Sadhasivam
2025-10-21T02:32:24Z

On Sat, Oct 18, 2025 at 07:07:35AM +0200, Niklas Cassel wrote:
> On 17 October 2025 18:45:58 CEST, Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> (snip)
>
> >>
> >> Thus, prevent advertising L1 Substates support until proper driver support
> >> is added.
> >
> >I think Mani is planning a change so we don't try to enable L1
> >Substates by default, which should avoid the regression even without a
> >patch like this.
>
> Sounds good, I suggested the same:
> https://lore.kernel.org/linux-pci/aO9tWjgHnkATroNa@ryzen/
>
>
> >
> >That will still leave the existing CONFIG_PCIEASPM_POWER_SUPERSAVE=y
> >and sysfs l1_1_aspm problems.
>
> Indeed, which is why I think that this patch is v6.18 material.
>

Not strictly a 6.18 material as the Kconfig/sysfs/cmdline issues existed even
before we enabled the ASPM states by default in v6.18-rc1.

The default ASPM issue will be fixed by a separate patch which will be generic
for all platforms. I'll apply this patch for v6.19.

- Mani

--
மணிவண்ணன் சதாசிவம்