From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9337CEE35F for ; Tue, 18 Nov 2025 21:43:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=dAXgsz7Eo/di1S07hoMUN8DVot90PGWWmY44uXdjk1Q=; b=HRTcTWUJZxw6nM vPuJSQTHTOq+FO8POn6tZ0Pcv/l1sq5MfAgdMxTEWXlZvsgCg3Foc45IueIefzs9uTOUod8hQb8gP EOVA1+Y5YkNbSyjDWWIoPljB0776Mm8R4TSEnmgEkKDFExBd2+jh4YsNp20BiUxf6Y03INpEkAh6N GnZqU6ltZPLAZlUAjWwdy5zw7PkKvlrHUc5Z8xnp32MdksyIGcBpxUEEhl+SKN16ikIInGnI4J2xj ILjs0cqPe0TFEC1jMF4oyMFoP3Nzb2ImkGFW/S2njK4zy/kfWBhKqeQWdWaMW1x1NDvuexSwEgro1 aIZF+ot55r4C9AIZKCJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vLTTs-000000018N6-2zTv; Tue, 18 Nov 2025 21:43:20 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vLTTr-000000018Mt-1tsJ; Tue, 18 Nov 2025 21:43:19 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 611756012B; Tue, 18 Nov 2025 21:43:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7BA5EC116D0; Tue, 18 Nov 2025 21:43:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763502197; bh=/DccbKxo0GnChl0C4CIrCj7Yv1sCs/9h37/YbO1FOhc=; h=From:To:Cc:Subject:Date:From; b=Fyr+5b1ioHIeLhruTgMZkGBFVJxUB2oLgyjAaqAPof7E+l81wsBvvAgQXLALgur/G sdW6SzakuazlI7jfz2o5EuyliPlZI6jtYVOvzZeN5HKcGvTugn36M5q/fV5ryci2w6 5MEx/1IFXpP79/mxWJmTYfsdqdQIvXT1GeqblkeXq0nC0x5jWRCUEfasZX8esesa1A V1BuZOGMemWf22F8MxLOrtf6WmBJzO2gnKNuCo8MoGgXZFYI2y5erH5z64T1PsSOl/ QFA6uRjpV66DA7FnPvvxl3m4wRVtlU0o4aLqM/Kmra9OYsqFThkLSmuqfzTVaTNXLF VGTfqqAvccj4Q== From: Bjorn Helgaas To: Niklas Cassel , Shawn Lin Cc: Manivannan Sadhasivam , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Rob Herring , Heiko Stuebner , Kever Yang , Simon Xue , Damien Le Moal , Dragan Simic , FUKAUMI Naoki , Diederik de Haas , Richard Zhu , Frank Li , Lucas Stach , Shawn Guo , Sascha Hauer , Fabio Estevam , Conor Dooley , Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter , Hans Zhang , linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@pengutronix.de, Bjorn Helgaas Subject: [PATCH v2 0/4] PCI: dwc: Advertise L1 PM Substates only if driver requests it Date: Tue, 18 Nov 2025 15:42:14 -0600 Message-ID: <20251118214312.2598220-1-helgaas@kernel.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: Bjorn Helgaas This is a follow-up to Niklas's patch at https://lore.kernel.org/r/20251017163252.598812-2-cassel@kernel.org. That patch clears the L1 PM Substate Supported bits for the dw-rockchip driver, which doesn't yet do the device configuration to support the L1 Substates. This series does the same thing, but in the DWC core so it applies to all DWC-based drivers. Drivers that do support L1 Substates (currently tegra194 and qcom) indicate that by setting "dw_pcie.l1ss_support", and the DWC core will leave the L1 PM Substate Supported bits alone. This also includes Shawn's patches to add the dw-rockchip support for L1 Substates. The problem this fixes is that users are currently able to enable L1 Substates, e.g., by - building with with CONFIG_PCIEASPM_POWER_SUPERSAVE=y - booting with "pcie_aspm.policy=powersupersave" - echo powersupersave > /sys/module/pcie_aspm/parameters/policy - echo 1 > /sys/bus/pci/devices/.../link/l1_1_aspm but this breaks devices if the platform doesn't support CLKREQ# or lacks Root Port configuration. This series avoids that problem by preventing the kernel from enabling L1.x in the first place. Bjorn Helgaas (2): PCI: dwc: Advertise L1 PM Substates only if driver requests it PCI: tegra194: Remove unnecessary L1SS disable code Shawn Lin (2): PCI: dw-rockchip: Configure L1SS support arm64: dts: rockchip: Add PCIe clkreq stuff for RK3588 EVB1 .../boot/dts/rockchip/rk3588-evb1-v10.dts | 7 ++- .../pci/controller/dwc/pcie-designware-ep.c | 2 + .../pci/controller/dwc/pcie-designware-host.c | 2 + drivers/pci/controller/dwc/pcie-designware.c | 24 ++++++++++ drivers/pci/controller/dwc/pcie-designware.h | 2 + drivers/pci/controller/dwc/pcie-dw-rockchip.c | 40 ++++++++++++++++ drivers/pci/controller/dwc/pcie-qcom.c | 2 + drivers/pci/controller/dwc/pcie-tegra194.c | 48 ++++--------------- 8 files changed, 85 insertions(+), 42 deletions(-) -- 2.43.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip