From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD9B1CFD2F6 for ; Sat, 29 Nov 2025 16:50:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=wzjJJ1Hrce9IPZECPLoGQtcYmAyLQRYq//aSTaedam0=; b=N0C4Fg+kdxhJxm et7Sk9TG3tt9y8bKvnQungH20HggEkqmkIBSLMQn8IMvt4PX19hH4/fmNQl5Fghf9vHkN4XIe2I7D jGt5o5c4a5y/oUPyJmUJSf2FblJl96PAgZzbXuVbvF/p2yZFYQrHjs3Ep7gayPyCN34ughk4+QRO8 5vm4rq6PhfzvsGQBhVk0sE2ZC4Mgrq8HPwKApY+oP77Qn+18cgeFcARJIHpy2RQyOGNokoZXUapye Kv/PxE0K4UkV6fiMWFFNuBAAtakQeGqDkZwL/0fKLB8jEJnRtBh7hWks8ewKzEJAJR+rpYQe6L/A8 XMfg5iEP9vqrMQp6CWRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vPO9X-00000001gDk-3bUU; Sat, 29 Nov 2025 16:50:31 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vPO9V-00000001gCz-0kqf for linux-rockchip@lists.infradead.org; Sat, 29 Nov 2025 16:50:30 +0000 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4779cb0a33fso27441665e9.0 for ; Sat, 29 Nov 2025 08:50:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764435027; x=1765039827; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+u+kxqq4MMJGawqIDaTzXliKugbB0Ij2lnspVyD3E7E=; b=Qqdcus/o3VXHq7Gd4vwpA4878PFDi19U3PKskpmR3iGqnLVun/uEDmAUZkTdeqMZHZ YrAW0OhI1lBUOZ9Q83bhR3wT78+JF5gkbhfbAvXOXskOpYU2GXiQBdqTuB/rYWY2o+26 N9svypi3pQa9OTczdGb78mBTTwty3wHjTOFqYxCcx4yqdgaxxjbAmJKSUiiRZwWC5hW2 pRJr9DqDMEqfQonrj8bEvIjxh88QFFj+iKAOUl1sqVXLp0vNBWsN21ghdyVNU76r20Rn ijX3B+A/FOtwRnYE2rAXMMD+l4C7DN0uDGnrWNU/+WOLus/6l0+Jv5/EPECG4abh2j7c IKkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764435027; x=1765039827; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+u+kxqq4MMJGawqIDaTzXliKugbB0Ij2lnspVyD3E7E=; b=b9ApA6TxmmGiyKiuEXdRc+rI9kouLdSqYNx8h3aYKVG1vanXZOwn7JU7rg0lp9n26S Oh3+ofoDByNjtJK2EodAT1sqpZDF1K7PdMTlZzJloOQegMUEjDJhUX6mH0UVmCD0tfev wrJqvVuOuYC5AG2LZ8dBW+pYLBVvQ4ljjxG33fppBG2J58muXA+gUsr+fkmpp7MZQUck djjCYuxkDsZCSWrR7BCsclel7RwtYEz7E88PYfHY6msqBq+iotVib8ubc2DjJsDnbF/F nkuaMmw/gstSx7gMeMDSsp8VVDT3hwDmWSAhHK2Te75aUbw06VMEbQ5Mv0bunwPAckq1 PdKQ== X-Forwarded-Encrypted: i=1; AJvYcCWekWctPSq93HJHz2mUpXerXbyCht8TxPcdjhxM9DayWrg17v+xeMzgkpp2wEljyzI1CtvDe/FfQqpgHrn8yg==@lists.infradead.org X-Gm-Message-State: AOJu0Ywgu6E/U0vX63JborlaGBi2owYKLVu3c9ADWu/7EqnzpiqM56Dp EEyYGFt3sl0tPqJtTY3J2TmM12Vtrw1hM2IWvuFNuCeS76gKGNIeU0C3d/1PrV+QiMM= X-Gm-Gg: ASbGnctgqtdmntZ36/GcKJDCh0hZEzuX8l7lgTDLYdVuhMY2eRTFnBHrVcVB0jb/ZXN /PbcaBG0dK+ksdqyqPPd0k14NXQxO53+Pp35y4ngs5Q+UTSMGslbzzhuD5S0SKS1Wq/xbDDvxFG mBBCEP43KeihBfcaGpDJHmzFS1TU3Et8vXtQGFbU42k08zcgv0uA008ui92oltYL8GucS9QRazo FfjOeIz2RGmR81zU96kNg6I7g32tF1rqI8vPXY8SlNZUmV3UT6e0z+CEqe6EkOYidX/x0I2tf08 9jyK4HOz5dDBx6RSjPGXpbEUp/94vMsNr+peS/K8QnwTTt8zo5b7lCMYaroo3fl48iqS/oKUVvu OBVOzbPXBx7qDrUevl/cJSmeg8jilpUqRQfOoO69MFEnwv3xqMkKDDTdz/3l1eJTudZCHrrTKnJ G0iFwnOP1eALzEzsB9 X-Google-Smtp-Source: AGHT+IGEoZUwPFD59KrJidNkG9F67yymewSdufIMxYqDAzd7rSdFYU/UTCa8BEI6YpP6tuO8Wx01SA== X-Received: by 2002:a05:600c:46cc:b0:477:7b16:5fb1 with SMTP id 5b1f17b1804b1-477c0174856mr324752135e9.7.1764435026599; Sat, 29 Nov 2025 08:50:26 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4791115caa7sm144049695e9.6.2025.11.29.08.50.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 08:50:26 -0800 (PST) Date: Sat, 29 Nov 2025 19:50:22 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Niklas Cassel , Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Heiko Stuebner Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, FUKAUMI Naoki , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] PCI: dwc: Make Link Up IRQ logic handle already powered on PCIe switches Message-ID: <202511290255.uBLXDIG5-lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20251127134318.3655052-2-cassel@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251129_085029_256350_D8F194A6 X-CRM114-Status: UNSURE ( 9.11 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Niklas, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Niklas-Cassel/PCI-dwc-Make-Link-Up-IRQ-logic-handle-already-powered-on-PCIe-switches/20251127-214649 base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next patch link: https://lore.kernel.org/r/20251127134318.3655052-2-cassel%40kernel.org patch subject: [PATCH] PCI: dwc: Make Link Up IRQ logic handle already powered on PCIe switches config: x86_64-randconfig-r071-20251128 (https://download.01.org/0day-ci/archive/20251129/202511290255.uBLXDIG5-lkp@intel.com/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202511290255.uBLXDIG5-lkp@intel.com/ smatch warnings: drivers/pci/controller/dwc/pcie-designware-host.c:737 dw_pcie_host_init() warn: missing error code 'ret' vim +/ret +737 drivers/pci/controller/dwc/pcie-designware-host.c 59fbab1ae40eb0 drivers/pci/controller/dwc/pcie-designware-host.c Rob Herring 2020-11-05 712 939fbcd568fd29 drivers/pci/controller/dwc/pcie-designware-host.c Serge Semin 2023-01-13 713 ret = dw_pcie_setup_rc(pp); 939fbcd568fd29 drivers/pci/controller/dwc/pcie-designware-host.c Serge Semin 2023-01-13 714 if (ret) 939fbcd568fd29 drivers/pci/controller/dwc/pcie-designware-host.c Serge Semin 2023-01-13 715 goto err_remove_edma; 939fbcd568fd29 drivers/pci/controller/dwc/pcie-designware-host.c Serge Semin 2023-01-13 716 c5097b9869a136 drivers/pci/controller/dwc/pcie-designware-host.c Johan Hovold 2023-07-06 717 if (!dw_pcie_link_up(pci)) { a37beefbde8802 drivers/pci/controller/dwc/pcie-designware-host.c Serge Semin 2022-06-24 718 ret = dw_pcie_start_link(pci); 886a9c1347558f drivers/pci/controller/dwc/pcie-designware-host.c Rob Herring 2020-11-05 719 if (ret) 939fbcd568fd29 drivers/pci/controller/dwc/pcie-designware-host.c Serge Semin 2023-01-13 720 goto err_remove_edma; da56a1bfbab551 drivers/pci/controller/dwc/pcie-designware-host.c Ajay Agarwal 2023-04-12 721 } 886a9c1347558f drivers/pci/controller/dwc/pcie-designware-host.c Rob Herring 2020-11-05 722 8d3bf19f1b585a drivers/pci/controller/dwc/pcie-designware-host.c Krishna chaitanya chundru 2024-11-23 723 /* 8d3bf19f1b585a drivers/pci/controller/dwc/pcie-designware-host.c Krishna chaitanya chundru 2024-11-23 724 * Note: Skip the link up delay only when a Link Up IRQ is present. 8d3bf19f1b585a drivers/pci/controller/dwc/pcie-designware-host.c Krishna chaitanya chundru 2024-11-23 725 * If there is no Link Up IRQ, we should not bypass the delay 8d3bf19f1b585a drivers/pci/controller/dwc/pcie-designware-host.c Krishna chaitanya chundru 2024-11-23 726 * because that would require users to manually rescan for devices. 8d3bf19f1b585a drivers/pci/controller/dwc/pcie-designware-host.c Krishna chaitanya chundru 2024-11-23 727 */ cd723d3dce14ac drivers/pci/controller/dwc/pcie-designware-host.c Niklas Cassel 2025-11-27 728 if (!pp->use_linkup_irq) { c5097b9869a136 drivers/pci/controller/dwc/pcie-designware-host.c Johan Hovold 2023-07-06 729 /* Ignore errors, the link may come up later */ c5097b9869a136 drivers/pci/controller/dwc/pcie-designware-host.c Johan Hovold 2023-07-06 730 dw_pcie_wait_for_link(pci); c5097b9869a136 drivers/pci/controller/dwc/pcie-designware-host.c Johan Hovold 2023-07-06 731 cd723d3dce14ac drivers/pci/controller/dwc/pcie-designware-host.c Niklas Cassel 2025-11-27 732 /* cd723d3dce14ac drivers/pci/controller/dwc/pcie-designware-host.c Niklas Cassel 2025-11-27 733 * For platforms with Link Up IRQ, initial scan will be done cd723d3dce14ac drivers/pci/controller/dwc/pcie-designware-host.c Niklas Cassel 2025-11-27 734 * on first Link Up IRQ. cd723d3dce14ac drivers/pci/controller/dwc/pcie-designware-host.c Niklas Cassel 2025-11-27 735 */ cd723d3dce14ac drivers/pci/controller/dwc/pcie-designware-host.c Niklas Cassel 2025-11-27 736 if (dw_pcie_host_initial_scan(pp)) 113fa857b74c94 drivers/pci/controller/dwc/pcie-designware-host.c Serge Semin 2022-06-24 @737 goto err_stop_link; ret = dw_pcie_host_initial_scan(pp); if (ret) goto err_stop_link; cd723d3dce14ac drivers/pci/controller/dwc/pcie-designware-host.c Niklas Cassel 2025-11-27 738 } 4fbfa17f9a0755 drivers/pci/controller/dwc/pcie-designware-host.c Shradha Todi 2025-02-21 739 feb85d9b1c47ea drivers/pci/dwc/pcie-designware-host.c Kishon Vijay Abraham I 2017-02-15 740 return 0; feb85d9b1c47ea drivers/pci/dwc/pcie-designware-host.c Kishon Vijay Abraham I 2017-02-15 741 113fa857b74c94 drivers/pci/controller/dwc/pcie-designware-host.c Serge Semin 2022-06-24 742 err_stop_link: a37beefbde8802 drivers/pci/controller/dwc/pcie-designware-host.c Serge Semin 2022-06-24 743 dw_pcie_stop_link(pci); 113fa857b74c94 drivers/pci/controller/dwc/pcie-designware-host.c Serge Semin 2022-06-24 744 939fbcd568fd29 drivers/pci/controller/dwc/pcie-designware-host.c Serge Semin 2023-01-13 745 err_remove_edma: 939fbcd568fd29 drivers/pci/controller/dwc/pcie-designware-host.c Serge Semin 2023-01-13 746 dw_pcie_edma_remove(pci); 939fbcd568fd29 drivers/pci/controller/dwc/pcie-designware-host.c Serge Semin 2023-01-13 747 9e2b5de5604a6f drivers/pci/controller/dwc/pcie-designware-host.c Jisheng Zhang 2019-03-29 748 err_free_msi: f78f02638af594 drivers/pci/controller/dwc/pcie-designware-host.c Rob Herring 2020-11-05 749 if (pp->has_msi_ctrl) 9e2b5de5604a6f drivers/pci/controller/dwc/pcie-designware-host.c Jisheng Zhang 2019-03-29 750 dw_pcie_free_msi(pp); c6481d51dc65f2 drivers/pci/controller/dwc/pcie-designware-host.c Serge Semin 2022-06-24 751 c6481d51dc65f2 drivers/pci/controller/dwc/pcie-designware-host.c Serge Semin 2022-06-24 752 err_deinit_host: aea370b2aec9d3 drivers/pci/controller/dwc/pcie-designware-host.c Yoshihiro Shimoda 2023-12-20 753 if (pp->ops->deinit) aea370b2aec9d3 drivers/pci/controller/dwc/pcie-designware-host.c Yoshihiro Shimoda 2023-12-20 754 pp->ops->deinit(pp); c6481d51dc65f2 drivers/pci/controller/dwc/pcie-designware-host.c Serge Semin 2022-06-24 755 f6fd357f7afbeb drivers/pci/controller/dwc/pcie-designware-host.c Krishna Chaitanya Chundru 2025-09-23 756 err_free_ecam: f6fd357f7afbeb drivers/pci/controller/dwc/pcie-designware-host.c Krishna Chaitanya Chundru 2025-09-23 757 if (pp->cfg) f6fd357f7afbeb drivers/pci/controller/dwc/pcie-designware-host.c Krishna Chaitanya Chundru 2025-09-23 758 pci_ecam_free(pp->cfg); f6fd357f7afbeb drivers/pci/controller/dwc/pcie-designware-host.c Krishna Chaitanya Chundru 2025-09-23 759 feb85d9b1c47ea drivers/pci/dwc/pcie-designware-host.c Kishon Vijay Abraham I 2017-02-15 760 return ret; feb85d9b1c47ea drivers/pci/dwc/pcie-designware-host.c Kishon Vijay Abraham I 2017-02-15 761 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip