Re: [PATCH v13 3/4] drm/atomic-helper: Re-order bridge chain pre-enable and post-disable

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Vicente Bergas <vicencb@gmail.com>
Cc: "Aradhya Bhatia" <aradhya.bhatia@linux.dev>,
	airlied@gmail.com, alexander.sverdlin@siemens.com,
	andrzej.hajda@intel.com,
	dri-devel <dri-devel@lists.freedesktop.org>,
	jernej.skrabec@gmail.com, "Jonas Karlman" <jonas@kwiboo.se>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	lumag@kernel.org, maarten.lankhorst@linux.intel.com,
	mripard@kernel.org, neil.armstrong@linaro.org, nm@ti.com,
	rfoss@kernel.org, simona@ffwll.ch,
	tomi.valkeinen@ideasonboard.com, tzimmermann@suse.de,
	vigneshr@ti.com,
	"Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>,
	"Douglas Anderson" <dianders@chromium.org>,
	"Damon Ding" <damon.ding@rock-chips.com>,
	"Sandy Huang" <hjc@rock-chips.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Andy Yan" <andy.yan@rock-chips.com>,
	"Linux Rockchip Support List"
	<linux-rockchip@lists.infradead.org>,
	"Devarsh Thakkar" <devarsht@ti.com>,
	"Linus Walleij" <linusw@kernel.org>,
	"Marek Vasut" <marek.vasut+renesas@mailbox.org>
Subject: Re: [PATCH v13 3/4] drm/atomic-helper: Re-order bridge chain pre-enable and post-disable
Date: Tue, 2 Dec 2025 15:29:11 +0900	[thread overview]
Message-ID: <20251202062911.GA24150@pendragon.ideasonboard.com> (raw)
In-Reply-To: <CAAMcf8Di8sc_XVZAnzQ9sUiUf-Ayvg2yjhx2dWmvvCnfF3pBRA@mail.gmail.com>

+Linus, Marek and Tomi.

On Mon, Dec 01, 2025 at 08:34:37PM +0100, Vicente Bergas wrote:
> On Mon, Oct 6, 2025 at 5:30 PM Aradhya Bhatia <aradhya.bhatia@linux.dev> wrote:
> >
> > +rockchip maintainers
> >
> > Hi Vicente, all,
> 
> Hi everybody,
> please, can some expert on this platform take a look at this bug?

There are similar issues with MCDE and R-Car DU, see
https://lore.kernel.org/all/CAD++jLkNCH=8VmwXh0UJS5QZ9wB-iP2kinytT+__fq0L1PzoZQ@mail.gmail.com/

I think we should revert commit c9b1150a68d9362a0827609fc0dc1664c0d8bfe1
and work on a clean solution. It broke too many drivers.

> > I went through the drivers and the affected areas in the gru-kevin
> > chromebook pipeline last week, but nothing has stood out.
> >
> >
> > Pipeline:
> >
> > rockchip,display-subsystem / rk3399-vop (Big/Lite) (CRTC) ->
> > rk3399-edp (Encoder) -> analogix_dp_core (Bridge) ->
> > sharp,lq123p (edp-panel)
> >
> > I am unable to debug this further since I do not have the hardware.
> >
> > I could use some help, especially from folks who understand the hardware
> > requirements better.
> >
> >
> > On 11/09/25 09:01, Aradhya Bhatia wrote:
> > > Hi Vicente,
> > >
> > > Thank you for the bisection and reporting the issue.
> > >
> > > On 10/09/25 16:17, Vicente Bergas wrote:
> > >> Hi,
> > >> this patch causes a regression. It has been reported in
> > >> https://bugzilla.kernel.org/show_bug.cgi?id=220554
> > >>
> > >> It affects the gru/kevin platform (arm64,RK3399) with the Panfrost DRM driver.
> > >
> > > I believe the Panfrost DRM driver may only be for the GPU.
> > >
> > > Based on the dts files in arm64/rockchip/, this is the pipeline of the
> > > gru-kevin setup that I understand.
> > >
> > >       rk3399-vop (Big/Lite) -> rk3399-edp -> sharp,lq123p (edp-panel)
> > >
> > > The setup seems to be using the drm/rockchip drivers for the display
> > > controller and for the bridge.
> > >
> > >>
> > >> When it boots in console mode, the blinking of the cursor keeps the display on.
> > >> If it is turned off via /sys/class/graphics/fbcon/cursor_blink, then
> > >> the display briefly shows each key press presented on screen for less
> > >> than one second and then powers off.
> > >>
> > >> When starting the graphical mode (wayland), if there are no
> > >> applications drawing on the screen, the only way to keep the display
> > >> on is by continuously moving the mouse.
> > >>
> > >
> > > Okay!
> > >
> > > I will have a look through the drivers. In the meanwhile, please do
> > > report back if you find any other observations.

-- 
Regards,

Laurent Pinchart

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip