From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
To: "Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Andy Yan" <andy.yan@rock-chips.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>
Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org,
Daniel Stone <daniels@collabora.com>,
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Subject: [PATCH v2 1/8] drm/rockchip: vop2: Switch impossible format conditional to WARN_ON
Date: Sat, 06 Dec 2025 21:45:11 +0100 [thread overview]
Message-ID: <20251206-vop2-atomic-fixups-v2-1-7fb45bbfbebd@collabora.com> (raw)
In-Reply-To: <20251206-vop2-atomic-fixups-v2-0-7fb45bbfbebd@collabora.com>
From: Daniel Stone <daniels@collabora.com>
We should never be able to create a framebuffer with an unsupported
format, so throw a warning if this ever happens, instead of attempting
to stagger on.
Signed-off-by: Daniel Stone <daniels@collabora.com>
Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
---
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
index 498df0ce4680..20b49209ddcd 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
@@ -1030,7 +1030,8 @@ static int vop2_plane_atomic_check(struct drm_plane *plane,
return 0;
format = vop2_convert_format(fb->format->format);
- if (format < 0)
+ /* We shouldn't be able to create a fb for an unsupported format */
+ if (WARN_ON(format < 0))
return format;
/* Co-ordinates have now been clipped */
--
2.52.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-12-06 20:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-06 20:45 [PATCH v2 0/8] drm/rockchip: No more post-atomic_check fixups Nicolas Frattaroli
2025-12-06 20:45 ` Nicolas Frattaroli [this message]
2026-01-20 12:49 ` [PATCH v2 1/8] drm/rockchip: vop2: Switch impossible format conditional to WARN_ON Thomas Zimmermann
2026-01-20 12:57 ` Nicolas Frattaroli
2025-12-06 20:45 ` [PATCH v2 2/8] drm/rockchip: vop2: Switch impossible pos " Nicolas Frattaroli
2026-01-20 12:52 ` Thomas Zimmermann
2025-12-06 20:45 ` [PATCH v2 3/8] drm/rockchip: vop2: Fix Esmart test condition Nicolas Frattaroli
2026-01-20 12:58 ` Thomas Zimmermann
2025-12-06 20:45 ` [PATCH v2 4/8] drm/rockchip: vop2: Enforce scaling workaround in plane_check Nicolas Frattaroli
2025-12-06 20:45 ` [PATCH v2 5/8] drm/rockchip: vop2: Enforce AFBC source alignment " Nicolas Frattaroli
2025-12-08 2:48 ` Chaoyi Chen
2025-12-08 7:24 ` Nicolas Frattaroli
2025-12-09 10:58 ` Nicolas Frattaroli
2025-12-11 11:06 ` Chaoyi Chen
2025-12-11 14:16 ` Nicolas Frattaroli
2025-12-12 9:59 ` Chaoyi Chen
2026-01-20 12:47 ` Andy Yan
2026-01-20 10:35 ` Daniel Stone
2025-12-06 20:45 ` [PATCH v2 6/8] drm/rockchip: vop2: Enforce AFBC transform stride align " Nicolas Frattaroli
2025-12-06 20:45 ` [PATCH v2 7/8] drm/rockchip: vop2: Use drm_is_afbc helper function Nicolas Frattaroli
2025-12-06 20:45 ` [PATCH v2 8/8] drm/rockchip: vop2: Simplify format_mod_supported Nicolas Frattaroli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251206-vop2-atomic-fixups-v2-1-7fb45bbfbebd@collabora.com \
--to=nicolas.frattaroli@collabora.com \
--cc=airlied@gmail.com \
--cc=andy.yan@rock-chips.com \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox