Re: [PATCH v2 1/4] arm64: dts: rockchip: use gated-fixed-clock for pcie-refclk on rk3588-jaguar

Shawn Lin
2026-02-11T14:20:49Z

Hi Heiko

在 2026/02/10 星期二 16:02, Heiko Stuebner 写道:
> From: Heiko Stuebner <heiko.stuebner@cherry.de>
>
> Using a combination of fixed clock and gpio-gate clock works but does
> not describe the actual hardware. Use the gated-fixed-clock binding
> to describe this in a nicer way.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
> ---
> .../arm64/boot/dts/rockchip/rk3588-jaguar.dts | 19 +++++--------------
> 1 file changed, 5 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts b/arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts
> index 952affaf455c..e21ad7575cb6 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts
> @@ -86,25 +86,16 @@ led-1 {
> };
> };
>
> - /*
> - * 100MHz reference clock for PCIe peripherals from PI6C557-05BLE
> - * clock generator.
> - * The clock output is gated via the OE pin on the clock generator.
> - * This is modeled as a fixed-clock plus a gpio-gate-clock.
> - */
> - pcie_refclk_gen: pcie-refclk-gen-clock {
> - compatible = "fixed-clock";
> + /* 100MHz PCIe reference clock from PI6C557-05BLE */
> + pcie_refclk: pcie-clock-generator {
> + compatible = "gated-fixed-clock";
> #clock-cells = <0>;
> clock-frequency = <100000000>;
> - };
> -
> - pcie_refclk: pcie-refclk-clock {
> - compatible = "gpio-gate-clock";
> - clocks = <&pcie_refclk_gen>;
> - #clock-cells = <0>;
> + clock-output-names = "pcie-refclk-clock";
> enable-gpios = <&gpio0 RK_PC6 GPIO_ACTIVE_LOW>; /* PCIE30X4_CLKREQN_M0 */
> pinctrl-names = "default";
> pinctrl-0 = <&pcie30x4_clkreqn_m0>;

This looks fine,

Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>

> + vdd-supply = <&vcca_3v3_s0>;
> };
>
> pps {