From: MidG971 <midgy971@gmail.com>
To: linux-rockchip@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
heiko@sntech.de, jonas@kwiboo.se, midgy971@gmail.com,
Claude <noreply@anthropic.com>
Subject: [PATCH v2] arm64: dts: rockchip: rock-3b: Model PI6C20100 as gated-fixed-clock
Date: Wed, 4 Mar 2026 14:29:57 +0100 [thread overview]
Message-ID: <20260304132957.684616-1-midgy971@gmail.com> (raw)
In-Reply-To: <20260213151452.535527-1-midgy971@gmail.com>
The Radxa ROCK 3B uses a PI6C20100 PCIe reference clock buffer to
provide a 100MHz reference clock to the PCIe 3.0 PHY and controllers.
This chip is currently modeled only as a fixed regulator
(vcc3v3_pi6c_03), with no clock output representation.
The PI6C20100 is a clock generator, not a power supply. Model it
properly as a gated-fixed-clock, following the pattern established
for the Rock 5 ITX and other boards with similar PCIe clock buffer
chips.
The regulator node is kept as-is since it controls the power supply
to the PI6C20100 chip via GPIO0_D4. The new gated-fixed-clock node
references this regulator as its vdd-supply and provides a proper
100MHz clock output. The pcie3x2 node is updated to include the
reference clock, matching the approach used in rk3588-rock-5-itx.dts.
Signed-off-by: Claude <noreply@anthropic.com>
Signed-off-by: MidG971 <midgy971@gmail.com>
---
Changes since v1 [1]:
- Drop phy-supply approach entirely (Jonas, Shawn)
- Model PI6C20100 as gated-fixed-clock instead
- Wire reference clock to pcie3x2 controller
- Follow pattern from rk3588-rock-5-itx.dts
[1] https://lore.kernel.org/linux-rockchip/20260213151452.535527-1-midgy971@gmail.com/
.../arm64/boot/dts/rockchip/rk3568-rock-3b.dts | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts
index 69001e4..24befc9 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts
@@ -56,7 +56,16 @@
};
};
- /* pi6c pcie clock generator */
+ /* PI6C20100 PCIe reference clock buffer (100MHz) */
+ pcie30_refclk: pcie-clock-generator {
+ compatible = "gated-fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <100000000>;
+ clock-output-names = "pcie30_refclk";
+ vdd-supply = <&vcc3v3_pi6c_03>;
+ };
+
+ /* PI6C20100 power supply - active-high GPIO0_D4 */
vcc3v3_pi6c_03: regulator-3v3-vcc-pi6c-03 {
compatible = "regulator-fixed";
enable-active-high;
@@ -553,6 +562,13 @@
};
&pcie3x2 {
+ clocks = <&cru ACLK_PCIE30X2_MST>, <&cru ACLK_PCIE30X2_SLV>,
+ <&cru ACLK_PCIE30X2_DBI>, <&cru PCLK_PCIE30X2>,
+ <&cru CLK_PCIE30X2_AUX_NDFT>,
+ <&pcie30_refclk>;
+ clock-names = "aclk_mst", "aclk_slv",
+ "aclk_dbi", "pclk", "aux",
+ "ref";
pinctrl-names = "default";
pinctrl-0 = <&pcie30x2m1_pins>;
reset-gpios = <&gpio2 RK_PD6 GPIO_ACTIVE_HIGH>;
--
2.39.5
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-03-04 13:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 15:14 [PATCH] arm64: dts: rockchip: rock-3b: Add phy-supply to pcie30phy MidG971
2026-02-13 16:10 ` Shawn Lin
2026-02-13 17:19 ` Jonas Karlman
2026-03-04 13:29 ` MidG971 [this message]
2026-03-04 13:57 ` [PATCH v2] arm64: dts: rockchip: rock-3b: Model PI6C20100 as gated-fixed-clock Shawn Lin
[not found] ` <shawn-reply-message-id>
2026-03-19 10:19 ` MidG971
2026-03-19 12:27 ` Shawn Lin
2026-03-19 14:51 ` [PATCH v4] " MidG971
2026-03-20 8:48 ` Heiko Stuebner
2026-03-20 9:44 ` [PATCH v5] " MidG971
2026-03-24 17:04 ` Heiko Stuebner
2026-03-24 17:15 ` Jonas Karlman
2026-03-24 22:27 ` Heiko Stuebner
2026-03-27 9:07 ` Midgy Balon
2026-03-20 10:28 ` [PATCH v4] " Midgy Balon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260304132957.684616-1-midgy971@gmail.com \
--to=midgy971@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=noreply@anthropic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox