Re: [PATCH 2/9] media: dt-bindings: add rockchip rk3588 vicap

From: Conor Dooley <conor@kernel.org>
To: michael.riesch@collabora.com
Cc: "Mehdi Djait" <mehdi.djait@linux.intel.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Kever Yang" <kever.yang@rock-chips.com>,
	"Jagan Teki" <jagan@amarulasolutions.com>,
	"Кузнецов Михаил" <mai.kuznetsov.misha@gmail.com>,
	"Sebastian Reichel" <sebastian.reichel@collabora.com>,
	"Nicolas Dufresne" <nicolas.dufresne@collabora.com>,
	"Collabora Kernel Team" <kernel@collabora.com>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/9] media: dt-bindings: add rockchip rk3588 vicap
Date: Fri, 13 Mar 2026 16:57:36 +0000	[thread overview]
Message-ID: <20260313-coyness-jab-ff0c85654555@spud> (raw)
In-Reply-To: <20260313-quickly-imperial-47638c9f0d4f@spud>

[-- Attachment #1.1: Type: text/plain, Size: 2038 bytes --]

On Fri, Mar 13, 2026 at 04:56:29PM +0000, Conor Dooley wrote:
> On Fri, Mar 13, 2026 at 04:20:44PM +0100, Michael Riesch via B4 Relay wrote:
> > From: Michael Riesch <michael.riesch@collabora.com>
> > 
> > Add documentation for the Rockchip RK3588 Video Capture (VICAP) unit.
> > 
> > Signed-off-by: Michael Riesch <michael.riesch@collabora.com>
> > ---
> >  .../bindings/media/rockchip,rk3588-vicap.yaml      | 256 +++++++++++++++++++++
> >  MAINTAINERS                                        |   1 +
> >  2 files changed, 257 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3588-vicap.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3588-vicap.yaml
> > new file mode 100644
> > index 000000000000..7fd4214921cb
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/rockchip,rk3588-vicap.yaml
> > @@ -0,0 +1,256 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/rockchip,rk3588-vicap.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Rockchip RK3588 Video Capture (VICAP)
> > +
> > +maintainers:
> > +  - Michael Riesch <michael.riesch@collabora.com>
> > +
> > +description:
> > +  The Rockchip RK3588 Video Capture (VICAP) block features a digital video
> > +  port (DVP, a parallel video interface) and six MIPI CSI-2 ports. It receives
> > +  the data from camera sensors, video decoders, or other companion ICs and
> > +  transfers it into system main memory by AXI bus and/or passes it to the image
> > +  signal processing (ISP) blocks.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - rockchip,rk3588-vicap
> 
> Curious why this cannot share a binding with the existing 3568-vicap.
> Looks pretty similar binding wise at least.
> If it's an entirely different architecture or whatever, please mention
> that in your commit message.

Looking further, it's using the same driver too...

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip