Linux-Rockchip Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: linux-iio@vger.kernel.org, andy@kernel.org, nuno.sa@analog.com,
	dlechner@baylibre.com, jean-baptiste.maneyrol@tdk.com,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	heiko@sntech.de, conor+dt@kernel.org, krzk+dt@kernel.org,
	robh@kernel.org, andriy.shevchenko@intel.com,
	Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH V2 2/5] iio: imu: inv_icm42600: Add support for using alternate registers
Date: Sat, 21 Mar 2026 17:50:36 +0000	[thread overview]
Message-ID: <20260321175036.50c6a29f@jic23-huawei> (raw)
In-Reply-To: <20260319182956.146976-3-macroalpha82@gmail.com>

On Thu, 19 Mar 2026 13:29:38 -0500
Chris Morgan <macroalpha82@gmail.com> wrote:

> From: Chris Morgan <macromorgan@hotmail.com>
> 
> Add support to the existing inv_icm42600 to support similar hardware
> with slightly different register layouts. For example the icm42607
> and icm42607p has most of the same functionality and even many of
> the same registers, but the addresses for indiviual registers differ.
> 
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>

> diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c
> index 11339ddf1da3..32aa2e52df2e 100644
> --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c
> +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c

> @@ -775,13 +774,13 @@ struct iio_dev *inv_icm42600_gyro_init(struct inv_icm42600_state *st)
>  	ret = devm_iio_kfifo_buffer_setup(dev, indio_dev,
>  					  &inv_icm42600_buffer_ops);
>  	if (ret)
> -		return ERR_PTR(ret);
> +		return ret;
>  
>  	ret = devm_iio_device_register(dev, indio_dev);

return devm_iio_device_register() now make sense.


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2026-03-21 17:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19 18:29 [PATCH v2 0/5] Add Invensense ICM42607 Chris Morgan
2026-03-19 18:29 ` [PATCH V2 1/5] dt-bindings: iio: imu: add icm42607 Chris Morgan
2026-03-20 17:39   ` Conor Dooley
2026-03-19 18:29 ` [PATCH V2 2/5] iio: imu: inv_icm42600: Add support for using alternate registers Chris Morgan
2026-03-21 17:50   ` Jonathan Cameron [this message]
2026-03-19 18:29 ` [PATCH V2 3/5] iio: imu: inv_icm42600: Add registers for icm42607 Chris Morgan
2026-03-21 17:25   ` Jonathan Cameron
2026-03-19 18:29 ` [PATCH V2 4/5] iio: imu: inv_icm42600: Add support " Chris Morgan
2026-03-20 16:44   ` kernel test robot
2026-03-20 16:55   ` kernel test robot
2026-03-21 17:48   ` Jonathan Cameron
2026-03-19 18:29 ` [PATCH V2 5/5] arm64: dts: rockchip: Add icm42607p IMU for RG-DS Chris Morgan
2026-03-19 19:55 ` [PATCH v2 0/5] Add Invensense ICM42607 Jean-Baptiste Maneyrol
2026-03-19 21:31   ` Chris Morgan
     [not found]   ` <abxrQ7MUw4QXnYZG@wintermute.localhost.fail>
2026-03-24 15:25     ` Chris Morgan
2026-03-20 20:00 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260321175036.50c6a29f@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=heiko@sntech.de \
    --cc=jean-baptiste.maneyrol@tdk.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=macroalpha82@gmail.com \
    --cc=macromorgan@hotmail.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox