From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17FA6F9935C for ; Thu, 23 Apr 2026 09:20:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W9zbxedpRIff+F8UH5Bk0v92FY1acGQAzPwADki57Oc=; b=cqjy9mxenXLmjN mc5rUqE+4SsD/gIhI+5OUCUGBuoYMacVlgU71AoQUk1PjmRGp7KU1jeIwAtOeI3lIPcCFtC0SdFiC TQnyl1Jl1EcDjnvL26jHvFx0/uOanzgw4TFDWohGhTXxtpcKknzVwFU7q4Nx5dASSJHBJXfJSHNRP mqTDGSXQYAEyrW0BdeeOkuTEQeJ53EzOUaH17Enqv5VB98NDAHgaRM5ppT75ZwygEjBbwK7vo7VvM UGSAIaEl+hphXdyFuuNdXRcwJcu+1yxI/CzIq9OtdTvRv2rnZ7f9B2I80k7vKMgoCc+4WVFGhvULm nroFLZc2LUv1Sr/Gi9LQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wFqE5-0000000BLAK-0MoB; Thu, 23 Apr 2026 09:20:01 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wFqE0-0000000BL8H-1gYA; Thu, 23 Apr 2026 09:19:57 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id A963C407D0; Thu, 23 Apr 2026 09:19:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF4B2C2BCAF; Thu, 23 Apr 2026 09:19:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776935995; bh=qKg5bxgpTTQfFUZxcCD9VWvBgzLKpR1Iot7so2sqo0I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mTxiAzAvZ7aeMDFlB8ptP+zBdIrxvGYToMwpCPaQ6IUiGmd97xPwNwHPocfDTmgfj 3peDCXfEW1IXekkaN7ymT0Eg7CfcXEs/NT4dIaOj9viGUg6yLTF3TOlEXwNwgUKaUc Fma3Yv00kKTj39H1p2VWps07J+EnS8jthRfRNATnWi4ewy4w5+crY4zW6b0ViUNOUZ Kyr1tjayGCVhd9UhkCi7Ger/qDGRF1+ges/MpE7ol36Ngj6wF3AFkIb37XVeV910+T gRKeDo7bhtpmt2HbNL3t7JvKS4vaurM2H3dzdGDA3VJL/bZxcfdtII8+fLAE2JOpqY nIiCVR1XfZcdw== Date: Thu, 23 Apr 2026 11:19:53 +0200 From: Krzysztof Kozlowski To: phucduc.bui@gmail.com Cc: Lee Jones , Mark Brown , Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Joseph Chen , Chris Zhong , Zhang Qing , David Rau , Animesh Agarwal , devicetree@vger.kernel.org, linux-sound@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ASoC: dt-bindings: drop redundant wakeup-source definitions Message-ID: <20260423-ingenious-psychedelic-jaybird-40bb4d@quoll> References: <20260423042831.21114-1-phucduc.bui@gmail.com> <20260423042831.21114-2-phucduc.bui@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260423042831.21114-2-phucduc.bui@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260423_021956_458420_500255CB X-CRM114-Status: GOOD ( 16.76 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Thu, Apr 23, 2026 at 11:28:31AM +0700, phucduc.bui@gmail.com wrote: > From: bui duc phuc > > The 'wakeup-source' property already has its type defined in the core TYPES. It is plural. > schema. A number of sound binding files redundantly specify the > 'type: boolean' and provide descriptions which only repeat the generic > meaning of the property. > Drop these redundant definitions and descriptions to clean up the binding > files and rely on the core schema instead. > No functional change intended. > > Signed-off-by: bui duc phuc > --- > Documentation/devicetree/bindings/sound/dialog,da7219.yaml | 5 +---- > Documentation/devicetree/bindings/sound/realtek,rt5514.yaml | 4 +--- > 2 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/sound/dialog,da7219.yaml b/Documentation/devicetree/bindings/sound/dialog,da7219.yaml > index 19137abdba3e..fab37cd92e0d 100644 > --- a/Documentation/devicetree/bindings/sound/dialog,da7219.yaml > +++ b/Documentation/devicetree/bindings/sound/dialog,da7219.yaml > @@ -45,10 +45,7 @@ properties: > - wakeup > - irq > > - wakeup-source: > - type: boolean > - description: > - Flag to indicate this device can wake system (suspend/resume). > + wakeup-source: true That's wrong. Commit msg is making here false statements that it is redundant. I checked (and you should too!) and driver does clearly device_property_read_bool() thus the property CANNOT be the second type. Best regards, Krzysztof _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip