Re: [PATCH 3/6] dt-bindings: display: panel: document Anbernic TD4310 panel

Krzysztof Kozlowski
2026-04-28T07:49:44Z

On Mon, Apr 27, 2026 at 12:09:11PM -0500, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> The panel used by Anbernic in the RG Vita-Pro is a DSI panel based
> on the TD4310 controller IC. It measures approximately 5.5 inches
> diagonally and is 1080x1920 in resolution.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
> .../display/panel/anbernic,td4310.yaml | 63 +++++++++++++++++++
> 1 file changed, 63 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/anbernic,td4310.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/anbernic,td4310.yaml b/Documentation/devicetree/bindings/display/panel/anbernic,td4310.yaml
> new file mode 100644
> index 000000000000..2da957cd5d49
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/anbernic,td4310.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/anbernic,td4310.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Anbernic TD4310 Based Panels
> +
> +maintainers:
> + - Chris Morgan <macromorgan@hotmail.com>
> +
> +description:
> + Bindings for Anbernic TD4310 Based Panels, such as the RG-Vita-Pro

Description says what the bindings are for. Your description says that
bindings are for "bindings for"... Just describe the hardware.

> + panel (a 1080x1920 5.5 inch panel).
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + items:
> + - const: anbernic,panel-vita-pro
> +
> + reg:
> + maxItems: 1
> +
> + vdd-supply:
> + description: Panel power supply
> +
> +required:
> + - compatible
> + - reg

supply as well. most likely

> + - reset-gpios
> + - port

Best regards,
Krzysztof